Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the completion of the process when the build fails #599

Open
gounthar opened this issue Jan 8, 2025 · 3 comments
Open

Allow the completion of the process when the build fails #599

gounthar opened this issue Jan 8, 2025 · 3 comments

Comments

@gounthar
Copy link
Collaborator

gounthar commented Jan 8, 2025

What feature do you want to see added?

Sometimes, the build fails, even for very simple recipes like SetupJenkinsfile.
For example, the acunetix plugin fails, and we do not apply the recipe:

Forking plugin acunetix locally from repo acunetix-plugin...
Synced the forked repository for plugin acunetix
Fetching plugin code locally acunetix...
Fetched repository from https://github.com/gounthar/acunetix-plugin.git to branch refs/heads/master
Collecting metadata for plugin acunetix... Please be patient
Build failed
Done
Failed to collect metadata for plugin acunetix. Will retry after a first compile using lowest JDK
Verifying plugin without tests acunetix using with JDK 8 ... Please be patient
Build failed

Would it be possible to mark certain recipes as "can be applied even if the build fails"? For this particular recipe, we are not changing the Java code, the dependencies, or even the Maven configuration, so the inability to build the project is not inherently problematic.

Additionally, I use the tool under WSL2, and we are aware that Jenkins plugin development and WSL2 are not always compatible. This could mean that a build might fail on my machine but succeed on the Jenkins infrastructure. I am not suggesting that all failed builds should be ignored for all recipes, but for some, it would make sense to allow them to proceed rather than simply giving up.

Upstream changes

No response

Are you interested in contributing this feature?

No response

@jonesbusy
Copy link
Collaborator

Initially there was a --skip-build option that I removed when moving to subcommand. This can be restored if needed.

The other solution I see is using a specific tag on the rewrite.yml recipe tags.

This would also accelerate running such recipes

@jonesbusy
Copy link
Collaborator

In the mentioned case I don't see how we can even run openrewrite.

It's not just compilation issue but some unknown dependencies

`org.jenkins-ci.main:jenkins-war:jar:war-for-test:2.73.3 was not found in https://repo.jenkins-ci.org/public/ during a previous attempt

https://www.jenkins.io/changelog-stable/2.73.1/

I will try to do my bust but it's not a simple build issue

@gounthar
Copy link
Collaborator Author

Thanks, I know there are some cases where we will have to do some things manually even before running the tool. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants