Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force the PR title/body if rerun #646

Open
gounthar opened this issue Jan 15, 2025 · 25 comments · May be fixed by #711
Open

Force the PR title/body if rerun #646

gounthar opened this issue Jan 15, 2025 · 25 comments · May be fixed by #711
Labels
good first issue Good for newcomers

Comments

@gounthar
Copy link
Collaborator

gounthar commented Jan 15, 2025 •
edited
Loading

What feature do you want to see added?

We've been running update campaigns for a while now, and some plugin maintainers have already reviewed and accepted our automatic PRs. However, some haven't reviewed or merged them, which was expected since the plugins we are targeting aren't as closely monitored as the most installed ones.

Whenever we relaunch a campaign on the same set of plugins, we force-push the same code, but it seems we don't modify the PR title and body. Between the campaigns, the text for the title and/or body may have changed because the project is evolving, and new JTE templates are being regularly updated.
Furthermore, some plugin maintainers gave some feedback (one of them being pretty harsh) about the PR body, so the PR body will evolve in order to satisfy most of the plugin maintainers.

That's why I propose that we consider changing the PR title and body when relaunching a campaign, provided the title and body haven't been edited since the PR was created.

Upstream changes

No response

Are you interested in contributing this feature?

No response
@jonesbusy jonesbusy added the good first issue Good for newcomers label Jan 16, 2025
@jonesbusy
Copy link
Collaborator

Makes sense definitely. Since we check a PR exists for a given repository and branch we could easily fetch the PR and update it's title and body.

Adding the good-first-issue tag

@gounthar
Copy link
Collaborator Author

Thanks!

@biru-codeastromer
Copy link

Hi Sir @gounthar May I work on this ?

@gounthar
Copy link
Collaborator Author

Hello @biru-codeastromer,

You're welcome to do so, thanks for your help. 👍

@biru-codeastromer
Copy link

Hello @biru-codeastromer,

You're welcome to do so, thanks for your help. 👍

Thanks Sir , will be raising a PR soon !

@biru-codeastromer
Copy link

Hello @biru-codeastromer,

You're welcome to do so, thanks for your help. 👍

Hi Sir, I wanted to tell you in the original setup and building process itself of the repo using maven , I am getting error in build without even making changes .

@jonesbusy
Copy link
Collaborator

Probably related to your environment

https://ci.jenkins.io/job/Tools/job/plugin-modernizer-tool/job/main/522/pipeline-graph/

Image

@gounthar
Copy link
Collaborator Author

What is your environment (OS, Java version and vendor, Maven version)?

@biru-codeastromer
Copy link

What is your environment (OS, Java version and vendor, Maven version)?

Hi Sir,

Thank you for your response. Here are the details of my environment:

Operating System: macOS Sequoia (Version 15.3 Beta)
Java Version: 23.0.1
Vendor: Homebrew
Runtime: /opt/homebrew/Cellar/openjdk/23.0.1/libexec/openjdk.jdk/Contents/Home
Maven Version: 3.9.9
Maven Home: /opt/homebrew/Cellar/maven/3.9.9/libexec

@biru-codeastromer
Copy link

Probably related to your environment

https://ci.jenkins.io/job/Tools/job/plugin-modernizer-tool/job/main/522/pipeline-graph/

Hello Sir this is what I am facing after running mvn clean install :

[INFO] Reactor Summary for Plugin Modernizer Parent 999999-SNAPSHOT:
[INFO] 
[INFO] Plugin Modernizer Parent ........................... SUCCESS [  1.155 s]
[INFO] Plugin Modernizer Core ............................. FAILURE [02:22 min]
[INFO] Plugin Modernizer CLI Interface .................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:23 min
[INFO] Finished at: 2025-01-24T18:42:18+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.spotbugs:spotbugs-maven-plugin:4.8.3.1:spotbugs (spotbugs) on project plugin-modernizer-core: Execution spotbugs of goal com.github.spotbugs:spotbugs-maven-plugin:4.8.3.1:spotbugs failed: Java returned: 1 -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :plugin-modernizer-core

@biru-codeastromer
Copy link

I suspect the issue might be related to SpotBugs compatibility with Java 23. Could you confirm if Java 23 is supported, or if there are additional configurations I should check?

@jonesbusy
Copy link
Collaborator

The jenkins project only support LTS version of Java (11, 17, 21 etc..) and 25 (end of the year).

There is no guarantee it works by using other Java version

@biru-codeastromer
Copy link

The jenkins project only support LTS version of Java (11, 17, 21 etc..) and 25 (end of the year).

There is no guarantee it works by using other Java version

Okay Sir , then I will try with 21 Version of java and update you here if I get successful .

Thanks for your help !

@biru-codeastromer
Copy link

biru-codeastromer commented Jan 24, 2025 •
edited
Loading

The jenkins project only support LTS version of Java (11, 17, 21 etc..) and 25 (end of the year).

There is no guarantee it works by using other Java version

Hi Sir,

I switched to Java 21 as per your suggestion, and the project built successfully 🎉. Thank you very much for your guidance!
I can make my changes and build again .

[INFO] --- install:3.1.3:install (default-install) @ plugin-modernizer-cli ---
[INFO] Installing /Users/birajitsaikia/Documents/pr-issueplugin/plugin-modernizer-tool/plugin-modernizer-cli/target/plugin-modernizer-cli-999999-SNAPSHOT.pom to /Users/birajitsaikia/.m2/repository/io/jenkins/plugin-modernizer/plugin-modernizer-cli/999999-SNAPSHOT/plugin-modernizer-cli-999999-SNAPSHOT.pom
[INFO] Installing /Users/birajitsaikia/Documents/pr-issueplugin/plugin-modernizer-tool/plugin-modernizer-cli/target/jenkins-plugin-modernizer-999999-SNAPSHOT.jar to /Users/birajitsaikia/.m2/repository/io/jenkins/plugin-modernizer/plugin-modernizer-cli/999999-SNAPSHOT/plugin-modernizer-cli-999999-SNAPSHOT.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Plugin Modernizer Parent 999999-SNAPSHOT:
[INFO] 
[INFO] Plugin Modernizer Parent ........................... SUCCESS [  1.067 s]
[INFO] Plugin Modernizer Core ............................. SUCCESS [02:36 min]
[INFO] Plugin Modernizer CLI Interface .................... SUCCESS [ 17.786 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:55 min
[INFO] Finished at: 2025-01-24T19:19:34+05:30
[INFO] ------------------------------------------------------------------------

@gounthar
Copy link
Collaborator Author

That's very good news, thanks for the feedback! 👍

@biru-codeastromer
Copy link

biru-codeastromer commented Jan 25, 2025 •
edited
Loading

Hi Sir ,

I wanted to bring to your attention some pre-existing test failures in the plugin-modernizer-tool project while running mvn test. While working on my recent changes, I noticed that the tests in DeclarativeRecipesTest were failing even before applying my modifications in GHServiceTest.java for confirming testes .

@biru-codeastromer
Copy link

biru-codeastromer commented Jan 25, 2025 •
edited
Loading

Details of the Failures:

-Test Name: upgradeNextMajorParentVersionTestWithBaseline

Other Similar Failures:

-upgradeNextMajorParentVersionTestWithBom
-upgradeToRecommendCoreVersionTest
-upgradeToRecommendCoreVersionTestWithBaseline
-upgradeToRecommendCoreVersionTestWithMultipleBom
-upgradeToUpgradeToLatestJava11CoreVersion

I verified that these failures are not related to my changes, as they persist even when reverting my modifications.

Steps I Took:
Reverted my changes and ran mvn testto confirm the errors were pre-existing.

@biru-codeastromer
Copy link

biru-codeastromer commented Jan 25, 2025 •
edited
Loading 

[ERROR] Failures: 
[ERROR]   DeclarativeRecipesTest.upgradeNextMajorParentVersionTestWithBaseline:1374 [Unexpected result in "pom.xml":
diff --git a/pom.xml b/pom.xml
index 7a3b716..b6459c9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -22,7 +22,7 @@ 
       <dependency>
         <groupId>io.jenkins.tools.bom</groupId>
         <artifactId>bom-${jenkins.baseline}.x</artifactId>
-        <version>3944.v1a_e4f8b_452db_</version>
+        <version>4023.va_eeb_b_4e45f07</version>
         <type>pom</type>
         <scope>import</scope>
       </dependency>
] 
expected: 
  "<?xml version="1.0" encoding="UTF-8"?>
  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>5.5</version>
      <relativePath />
    </parent>
    <groupId>io.jenkins.plugins</groupId>
    <artifactId>empty</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <packaging>hpi</packaging>
    <name>Empty Plugin</name>
    <properties>
       <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
       <jenkins.baseline>2.479</jenkins.baseline>
       <jenkins.version>${jenkins.baseline}.1</jenkins.version>
    </properties>
    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>io.jenkins.tools.bom</groupId>
          <artifactId>bom-${jenkins.baseline}.x</artifactId>
          <version>3944.v1a_e4f8b_452db_</version>
          <type>pom</type>
          <scope>import</scope>
        </dependency>
      </dependencies>
    </dependencyManagement>
    <repositories>
      <repository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </repository>
    </repositories>
    <pluginRepositories>
      <pluginRepository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </pluginRepository>
    </pluginRepositories>
  </project>"
 but was: 
  "<?xml version="1.0" encoding="UTF-8"?>
  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>5.5</version>
      <relativePath />
    </parent>
    <groupId>io.jenkins.plugins</groupId>
    <artifactId>empty</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <packaging>hpi</packaging>
    <name>Empty Plugin</name>
    <properties>
       <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
       <jenkins.baseline>2.479</jenkins.baseline>
       <jenkins.version>${jenkins.baseline}.1</jenkins.version>
    </properties>
    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>io.jenkins.tools.bom</groupId>
          <artifactId>bom-${jenkins.baseline}.x</artifactId>
          <version>4023.va_eeb_b_4e45f07</version>
          <type>pom</type>
          <scope>import</scope>
        </dependency>
      </dependencies>
    </dependencyManagement>
    <repositories>
      <repository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </repository>
    </repositories>
    <pluginRepositories>
      <pluginRepository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </pluginRepository>
    </pluginRepositories>
  </project>"
[ERROR]   DeclarativeRecipesTest.upgradeNextMajorParentVersionTestWithBom:1266 [Unexpected result in "pom.xml":
diff --git a/pom.xml b/pom.xml
index 7a3b716..b6459c9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -22,7 +22,7 @@ 
       <dependency>
         <groupId>io.jenkins.tools.bom</groupId>
         <artifactId>bom-${jenkins.baseline}.x</artifactId>
-        <version>3944.v1a_e4f8b_452db_</version>
+        <version>4023.va_eeb_b_4e45f07</version>
         <type>pom</type>
         <scope>import</scope>
       </dependency>
] 
expected: 
  "<?xml version="1.0" encoding="UTF-8"?>
  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>5.5</version>
      <relativePath />
    </parent>
    <groupId>io.jenkins.plugins</groupId>
    <artifactId>empty</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <packaging>hpi</packaging>
    <name>Empty Plugin</name>
    <properties>
       <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
       <jenkins.baseline>2.479</jenkins.baseline>
       <jenkins.version>${jenkins.baseline}.1</jenkins.version>
    </properties>
    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>io.jenkins.tools.bom</groupId>
          <artifactId>bom-${jenkins.baseline}.x</artifactId>
          <version>3944.v1a_e4f8b_452db_</version>
          <type>pom</type>
          <scope>import</scope>
        </dependency>
      </dependencies>
    </dependencyManagement>
    <repositories>
      <repository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </repository>
    </repositories>
    <pluginRepositories>
      <pluginRepository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </pluginRepository>
    </pluginRepositories>
  </project>"
 but was: 
  "<?xml version="1.0" encoding="UTF-8"?>
  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>5.5</version>
      <relativePath />
    </parent>
    <groupId>io.jenkins.plugins</groupId>
    <artifactId>empty</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <packaging>hpi</packaging>
    <name>Empty Plugin</name>
    <properties>
       <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
       <jenkins.baseline>2.479</jenkins.baseline>
       <jenkins.version>${jenkins.baseline}.1</jenkins.version>
    </properties>
    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>io.jenkins.tools.bom</groupId>
          <artifactId>bom-${jenkins.baseline}.x</artifactId>
          <version>4023.va_eeb_b_4e45f07</version>
          <type>pom</type>
          <scope>import</scope>
        </dependency>
      </dependencies>
    </dependencyManagement>
    <repositories>
      <repository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </repository>
    </repositories>
    <pluginRepositories>
      <pluginRepository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </pluginRepository>
    </pluginRepositories>
  </project>"
[ERROR]   DeclarativeRecipesTest.upgradeToRecommendCoreVersionTest:469 [Unexpected result in "pom.xml":
diff --git a/pom.xml b/pom.xml
index d5c90f3..d3b9d9a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -25,7 +25,7 @@ 
       <dependency>
         <groupId>io.jenkins.tools.bom</groupId>
         <artifactId>bom-${jenkins.baseline}.x</artifactId>
-        <version>3944.v1a_e4f8b_452db_</version>
+        <version>4023.va_eeb_b_4e45f07</version>
         <type>pom</type>
         <scope>import</scope>
       </dependency>
] 
expected: 
  "<?xml version="1.0" encoding="UTF-8"?>
  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>4.88</version>
      <relativePath />
    </parent>
    <groupId>io.jenkins.plugins</groupId>
    <artifactId>empty</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <packaging>hpi</packaging>
    <name>Empty Plugin</name>
    <scm>
      <connection>scm:git:https://github.com/jenkinsci/empty-plugin.git</connection>
    </scm>
    <properties>
      <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
      <jenkins.baseline>2.462</jenkins.baseline>
      <jenkins.version>${jenkins.baseline}.3</jenkins.version>
    </properties>
    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>io.jenkins.tools.bom</groupId>
          <artifactId>bom-${jenkins.baseline}.x</artifactId>
          <version>3944.v1a_e4f8b_452db_</version>
          <type>pom</type>
          <scope>import</scope>
        </dependency>
      </dependencies>
    </dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>io.jenkins.plugins</groupId>
        <artifactId>asm-api</artifactId>
      </dependency>
    </dependencies>
    <repositories>
      <repository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </repository>
    </repositories>
    <pluginRepositories>
      <pluginRepository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </pluginRepository>
    </pluginRepositories>
  </project>"
 but was: 
  "<?xml version="1.0" encoding="UTF-8"?>
  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>4.88</version>
      <relativePath />
    </parent>
    <groupId>io.jenkins.plugins</groupId>
    <artifactId>empty</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <packaging>hpi</packaging>
    <name>Empty Plugin</name>
    <scm>
      <connection>scm:git:https://github.com/jenkinsci/empty-plugin.git</connection>
    </scm>
    <properties>
      <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
      <jenkins.baseline>2.462</jenkins.baseline>
      <jenkins.version>${jenkins.baseline}.3</jenkins.version>
    </properties>
    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>io.jenkins.tools.bom</groupId>
          <artifactId>bom-${jenkins.baseline}.x</artifactId>
          <version>4023.va_eeb_b_4e45f07</version>
          <type>pom</type>
          <scope>import</scope>
        </dependency>
      </dependencies>
    </dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>io.jenkins.plugins</groupId>
        <artifactId>asm-api</artifactId>
      </dependency>
    </dependencies>
    <repositories>
      <repository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </repository>
    </repositories>
    <pluginRepositories>
      <pluginRepository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </pluginRepository>
    </pluginRepositories>
  </project>"
[ERROR]   DeclarativeRecipesTest.upgradeToRecommendCoreVersionTestWithBaseline:671 [Unexpected result in "pom.xml":
diff --git a/pom.xml b/pom.xml
index 1cfcfbe..be93275 100644
--- a/pom.xml
+++ b/pom.xml
@@ -22,7 +22,7 @@ 
       <dependency>
         <groupId>io.jenkins.tools.bom</groupId>
         <artifactId>bom-${jenkins.baseline}.x</artifactId>
-        <version>3944.v1a_e4f8b_452db_</version>
+        <version>4023.va_eeb_b_4e45f07</version>
         <type>pom</type>
         <scope>import</scope>
       </dependency>
] 
expected: 
  "<?xml version="1.0" encoding="UTF-8"?>
  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>4.88</version>
      <relativePath />
    </parent>
    <groupId>io.jenkins.plugins</groupId>
    <artifactId>empty</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <packaging>hpi</packaging>
    <name>Empty Plugin</name>
    <properties>
       <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
       <jenkins.baseline>2.462</jenkins.baseline>
       <jenkins.version>${jenkins.baseline}.3</jenkins.version>
    </properties>
    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>io.jenkins.tools.bom</groupId>
          <artifactId>bom-${jenkins.baseline}.x</artifactId>
          <version>3944.v1a_e4f8b_452db_</version>
          <type>pom</type>
          <scope>import</scope>
        </dependency>
      </dependencies>
    </dependencyManagement>
    <repositories>
      <repository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </repository>
    </repositories>
    <pluginRepositories>
      <pluginRepository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </pluginRepository>
    </pluginRepositories>
  </project>"
 but was: 
  "<?xml version="1.0" encoding="UTF-8"?>
  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>4.88</version>
      <relativePath />
    </parent>
    <groupId>io.jenkins.plugins</groupId>
    <artifactId>empty</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <packaging>hpi</packaging>
    <name>Empty Plugin</name>
    <properties>
       <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
       <jenkins.baseline>2.462</jenkins.baseline>
       <jenkins.version>${jenkins.baseline}.3</jenkins.version>
    </properties>
    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>io.jenkins.tools.bom</groupId>
          <artifactId>bom-${jenkins.baseline}.x</artifactId>
          <version>4023.va_eeb_b_4e45f07</version>
          <type>pom</type>
          <scope>import</scope>
        </dependency>
      </dependencies>
    </dependencyManagement>
    <repositories>
      <repository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </repository>
    </repositories>
    <pluginRepositories>
      <pluginRepository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </pluginRepository>
    </pluginRepositories>
  </project>"
[ERROR]   DeclarativeRecipesTest.upgradeToRecommendCoreVersionTestWithMultipleBom:775 [Unexpected result in "pom.xml":
diff --git a/pom.xml b/pom.xml
index 856f71e..1fe19f3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -42,7 +42,7 @@ 
       <dependency>
         <groupId>io.jenkins.tools.bom</groupId>
         <artifactId>bom-${jenkins.baseline}.x</artifactId>
-        <version>3944.v1a_e4f8b_452db_</version>
+        <version>4023.va_eeb_b_4e45f07</version>
         <scope>import</scope>
         <type>pom</type>
       </dependency>
] 
expected: 
  "<?xml version="1.0" encoding="UTF-8"?>
  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>4.88</version>
      <relativePath />
    </parent>
    <artifactId>empty</artifactId>
    <version>${revision}-${changelist}</version>
    <packaging>hpi</packaging>
    <name>My API Plugin</name>
    <properties>
      <revision>2.17.0</revision>
      <changelist>999999-SNAPSHOT</changelist>
      <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
      <jenkins.baseline>2.462</jenkins.baseline>
      <jenkins.version>${jenkins.baseline}.3</jenkins.version>
    </properties>
    <repositories>
      <repository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </repository>
    </repositories>
    <pluginRepositories>
      <pluginRepository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </pluginRepository>
    </pluginRepositories>
    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>com.fasterxml.jackson</groupId>
          <artifactId>jackson-bom</artifactId>
          <version>2.17.0</version>
          <scope>import</scope>
          <type>pom</type>
        </dependency>
        <dependency>
          <groupId>io.jenkins.tools.bom</groupId>
          <artifactId>bom-${jenkins.baseline}.x</artifactId>
          <version>3944.v1a_e4f8b_452db_</version>
          <scope>import</scope>
          <type>pom</type>
        </dependency>
      </dependencies>
    </dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>com.fasterxml.jackson.core</groupId>
        <artifactId>jackson-databind</artifactId>
      </dependency>
      <dependency>
        <groupId>io.jenkins.plugins</groupId>
        <artifactId>json-api</artifactId>
      </dependency>
    </dependencies>
  </project>"
 but was: 
  "<?xml version="1.0" encoding="UTF-8"?>
  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>4.88</version>
      <relativePath />
    </parent>
    <artifactId>empty</artifactId>
    <version>${revision}-${changelist}</version>
    <packaging>hpi</packaging>
    <name>My API Plugin</name>
    <properties>
      <revision>2.17.0</revision>
      <changelist>999999-SNAPSHOT</changelist>
      <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
      <jenkins.baseline>2.462</jenkins.baseline>
      <jenkins.version>${jenkins.baseline}.3</jenkins.version>
    </properties>
    <repositories>
      <repository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </repository>
    </repositories>
    <pluginRepositories>
      <pluginRepository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </pluginRepository>
    </pluginRepositories>
    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>com.fasterxml.jackson</groupId>
          <artifactId>jackson-bom</artifactId>
          <version>2.17.0</version>
          <scope>import</scope>
          <type>pom</type>
        </dependency>
        <dependency>
          <groupId>io.jenkins.tools.bom</groupId>
          <artifactId>bom-${jenkins.baseline}.x</artifactId>
          <version>4023.va_eeb_b_4e45f07</version>
          <scope>import</scope>
          <type>pom</type>
        </dependency>
      </dependencies>
    </dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>com.fasterxml.jackson.core</groupId>
        <artifactId>jackson-databind</artifactId>
      </dependency>
      <dependency>
        <groupId>io.jenkins.plugins</groupId>
        <artifactId>json-api</artifactId>
      </dependency>
    </dependencies>
  </project>"
[ERROR]   DeclarativeRecipesTest.upgradeToUpgradeToLatestJava11CoreVersion:918 [Unexpected result in "pom.xml":
diff --git a/pom.xml b/pom.xml
index ad46052..6abe76d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -25,7 +25,7 @@ 
       <dependency>
         <groupId>io.jenkins.tools.bom</groupId>
         <artifactId>bom-${jenkins.baseline}.x</artifactId>
-        <version>3944.v1a_e4f8b_452db_</version>
+        <version>4023.va_eeb_b_4e45f07</version>
         <type>pom</type>
         <scope>import</scope>
       </dependency>
] 
expected: 
  "<?xml version="1.0" encoding="UTF-8"?>
  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>4.88</version>
      <relativePath />
    </parent>
    <groupId>io.jenkins.plugins</groupId>
    <artifactId>empty</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <packaging>hpi</packaging>
    <name>Empty Plugin</name>
    <scm>
      <connection>scm:git:https://github.com/jenkinsci/empty-plugin.git</connection>
    </scm>
    <properties>
       <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
       <jenkins.baseline>2.462</jenkins.baseline>
       <jenkins.version>${jenkins.baseline}.3</jenkins.version>
    </properties>
    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>io.jenkins.tools.bom</groupId>
          <artifactId>bom-${jenkins.baseline}.x</artifactId>
          <version>3944.v1a_e4f8b_452db_</version>
          <type>pom</type>
          <scope>import</scope>
        </dependency>
      </dependencies>
    </dependencyManagement>
    <repositories>
      <repository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </repository>
    </repositories>
    <pluginRepositories>
      <pluginRepository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </pluginRepository>
    </pluginRepositories>
  </project>"
 but was: 
  "<?xml version="1.0" encoding="UTF-8"?>
  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>4.88</version>
      <relativePath />
    </parent>
    <groupId>io.jenkins.plugins</groupId>
    <artifactId>empty</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <packaging>hpi</packaging>
    <name>Empty Plugin</name>
    <scm>
      <connection>scm:git:https://github.com/jenkinsci/empty-plugin.git</connection>
    </scm>
    <properties>
       <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
       <jenkins.baseline>2.462</jenkins.baseline>
       <jenkins.version>${jenkins.baseline}.3</jenkins.version>
    </properties>
    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>io.jenkins.tools.bom</groupId>
          <artifactId>bom-${jenkins.baseline}.x</artifactId>
          <version>4023.va_eeb_b_4e45f07</version>
          <type>pom</type>
          <scope>import</scope>
        </dependency>
      </dependencies>
    </dependencyManagement>
    <repositories>
      <repository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </repository>
    </repositories>
    <pluginRepositories>
      <pluginRepository>
        <id>repo.jenkins-ci.org</id>
        <url>https://repo.jenkins-ci.org/public/</url>
      </pluginRepository>
    </pluginRepositories>
  </project>"
[INFO] 
[ERROR] Tests run: 260, Failures: 6, Errors: 0, Skipped: 3
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Plugin Modernizer Parent 999999-SNAPSHOT:
[INFO] 
[INFO] Plugin Modernizer Parent ........................... SUCCESS [  0.341 s]
[INFO] Plugin Modernizer Core ............................. FAILURE [03:24 min]
[INFO] Plugin Modernizer CLI Interface .................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:24 min
[INFO] Finished at: 2025-01-25T11:25:13+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test (default-test) on project plugin-modernizer-core: There are test failures.
[ERROR] 
[ERROR] See /Users/birajitsaikia/Documents/pr-issueplugin/plugin-modernizer-tool/plugin-modernizer-core/target/surefire-reports for the individual test results.
[ERROR] See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :plugin-modernizer-core

@biru-codeastromer
Copy link

biru-codeastromer commented Jan 25, 2025 •
edited
Loading

Do you think Sir I should raise the PR then without addressing the pre-existing test failures? These failures are not related to my changes, and if these test checks are not required for timing, I can proceed with the PR as is.

@jonesbusy
Copy link
Collaborator

Possibly related to #708

Your PR need to be rebased when merged on main.

This was cause by bom update (https://github.com/jenkinsci/bom/releases) and removal from 2.452.x line) and some tests still using hardcoded value

@biru-codeastromer
Copy link

Possibly related to #708

Your PR need to be rebased when merged on main.

This was cause by bom update (https://github.com/jenkinsci/bom/releases) and removal from 2.452.x line) and some tests still using hardcoded value

Thanks Sir for the confirmation . Okay I will proceed accordingly.

@biru-codeastromer biru-codeastromer linked a pull request Jan 25, 2025 that will close this issue
Open
6 tasks
@biru-codeastromer
Copy link 

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Plugin Modernizer Parent 999999-SNAPSHOT:
[INFO] 
[INFO] Plugin Modernizer Parent ........................... SUCCESS [  1.148 s]
[INFO] Plugin Modernizer Core ............................. FAILURE [02:20 min]
[INFO] Plugin Modernizer CLI Interface .................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:21 min
[INFO] Finished at: 2025-01-27T11:35:29+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.spotbugs:spotbugs-maven-plugin:4.8.3.1:spotbugs (spotbugs) on project plugin-modernizer-core: Execution spotbugs of goal com.github.spotbugs:spotbugs-maven-plugin:4.8.3.1:spotbugs failed: Java returned: 1 -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :plugin-modernizer-core

@biru-codeastromer
Copy link

I am again getting errors in mvn install.

@jonesbusy
Copy link
Collaborator

ci.jenkins.io is green. Double check your configuration

@biru-codeastromer
Copy link

ci.jenkins.io is green. Double check your configuration

Okay Sir !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PR title and body when relaunching a campaign biru-codeastromer/plugin-modernizer-tool
3 participants
@gounthar @jonesbusy @biru-codeastromer