Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not find preview URL when using Istio #207

Open
patrickleet opened this issue Jan 11, 2021 · 4 comments
Open

Can not find preview URL when using Istio #207

patrickleet opened this issue Jan 11, 2021 · 4 comments

Comments

@patrickleet
Copy link
Contributor

Does not check for virtual services

@patrickleet
Copy link
Contributor Author

patrickleet commented Jan 11, 2021

workaround for now:

        - image: gcr.io/jenkinsxio/jx-boot:3.1.86
          name: comment-with-link
          resources: {}
          script: |
            #!/usr/bin/env sh
            export PREVIEW_NAMESPACE=$(echo "jx-$REPO_OWNER-$REPO_NAME-pr-$PULL_NUMBER" | tr '[:upper:]' '[:lower:]')
            export VS_URL=$(kubectl get virtualservices -n $PREVIEW_NAMESPACE $REPO_NAME -o 'jsonpath={.spec.hosts[0]}')
            jx gitops pr comment \
              -c "🔥 PR Preview environment is using Istio - access the service [here](https://$VS_URL)" \
              --repo $REPO_OWNER/$REPO_NAME \
              --pr $PULL_NUMBER

@wowq
Copy link
Contributor

wowq commented Jul 19, 2021

Using the nginx ingress has the same issue

@joker00777
Copy link
Contributor

HI I tried to solve this problem this is the link for the pr:
jenkins-x/jx-helpers#375

@chrislovecnm
Copy link

Can we create a command line argument to pass in the url?? I think that is probably the simplest option. We are not using istio, ingress of a service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants