Ignore approvals from PR author present as approver in OWNERS file

[souvik-deepsource]

Is there a way to ignore approvals from PR authors who are added as approvers in the OWNERS file?

[ankitm123]

Not that I know of, what is the use case for this?

[souvik-deepsource]

There is a chance that the author might approve mistakenly. Basically, we want the PR author who is an approver to refrain from self approving his own PR.

[ankitm123]

This is currently not supported in lighthouse or prow (which is what lighthouse is forked from, atleast the version of prow which was the base of the lighthouse fork).
I will take a look later this week (I have a pending PR to complete before that).

[ankitm123]

/assign
I think this is a good feature to have. We can put it behind a feature flag, so that it does not break current workloads. So by default it will do what it's doing now, but u toggle a flag, and it removes self approval. wdyt?

[souvik-deepsource]

Yup, we want to remove self approval by PR authors who are approvers of the repo as well.