Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login failing for Amazon ECR public repository #170

Open
ravikishore1979 opened this issue Nov 2, 2023 · 2 comments
Open

login failing for Amazon ECR public repository #170

ravikishore1979 opened this issue Nov 2, 2023 · 2 comments

Comments

@ravikishore1979
Copy link

docker.withRegistry fails to login for a public repository but works with the private repository.
Can we use this plugin to login to the Amazon ECR public repository?

@Tesseract99
Copy link

I am facing this issue too. Pushing to Public ECR registry with this plugin doesn't work. Works fine for private ones.
I could not find any clarification regarding this in the readme either.

@TobiX
Copy link
Contributor

TobiX commented Jul 17, 2024

Public and private ECR repositories use completely different API endpoints and IAM objects (ecr:GetAuthorizationToken vs. ecr-public:GetAuthorizationToken), so this is no surprise. One could probably extend this plugin to support both (with a new "mapping prefix"), but it won't work out-of-the-box.

I'm not interested in implementing this myself, but I might merge an extension to this plugin (preferably with tests & without too much code duplication)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants