Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

casc config reports improper filter value #265

Open
bentlifetattoo opened this issue Mar 15, 2023 · 5 comments
Open

casc config reports improper filter value #265

bentlifetattoo opened this issue Mar 15, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@bentlifetattoo
Copy link

Jenkins and plugins versions report

when viewing the casc config, the filter value is reported as the object address.

 listSecrets:
      filters:
      - key: "name"
        values:
        - "io.jenkins.plugins.credentials.secretsmanager.config.Value@5cd22463"

What Operating System are you using (both controller, and any agents involved in the problem)?

linux

Reproduction steps

add a filter, view casc config

Expected Results

the value of the filter is displayed

Actual Results

object value displayed

Anything else?

No response

@bentlifetattoo bentlifetattoo added the bug Something isn't working label Mar 15, 2023
@chriskilding
Copy link
Contributor

Is this when you use the CasC export function to generate the YAML from Jenkins' existing configuration? (Just checking we're thinking of the same feature here. )

@bentlifetattoo
Copy link
Author

i believe so - i see it when i click the "view configuration" button. it's a minor issue as the fields are correct on the configuration page.

@chriskilding
Copy link
Contributor

@jetersen could you confirm how configuration classes are meant to expose their values for this "view configuration" page?

My first guess is that an extra method is needed for this on the descriptor of the io.jenkins.plugins.credentials.secretsmanager.config.Value class?

Alternatively does the "view configuration" page simply use toString() on the config objects, in which case I just need to override toString() for this?

@bentlifetattoo
Copy link
Author

screenshot:

Screenshot 2023-03-20 at 9 13 23 AM

@chriskilding
Copy link
Contributor

@jetersen could you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants