Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY-2786] Fixes for CSRF vulnerability and missing permission checks #189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stuartrowe
Copy link

Description

See JENKINS-71912 / SECURITY-2786.

Added permission checks to methods implementing form validation and additionally annotated the methods to require POST requests.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description.
  • Appropriate unit or acceptance tests or explanation to why this change has no tests.
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description.
  • Reviewed the code.
  • Verified that the appropriate tests have been written or valid explanation given.
  • If applicable, tested by installing this plugin on the Jenkins instance.

@stuartrowe
Copy link
Author

@nrayapati please review when you're able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant