From 0556d205faf4305608167e7659276675eefe30e6 Mon Sep 17 00:00:00 2001
From: Mark Waite <mark.earl.waite@gmail.com>
Date: Sat, 23 Dec 2023 08:03:45 -0700
Subject: [PATCH] Suppress existing spotbugs warnings

---
 pom.xml                         |  2 --
 src/spotbugs/excludesFilter.xml | 59 +++++++++++++++++++--------------
 2 files changed, 34 insertions(+), 27 deletions(-)

diff --git a/pom.xml b/pom.xml
index 6bb1022..04c56ec 100644
--- a/pom.xml
+++ b/pom.xml
@@ -17,8 +17,6 @@
     <description>Parses the console log generated by a build</description>
 
     <properties>
-        <!-- TODO: remove once FindBugs issues are fixed -->
-        <spotbugs.failOnError>false</spotbugs.failOnError>
         <jenkins.version>2.387.3</jenkins.version>
         <!-- Maven Plugins -->
         <maven-release-plugin.version>2.5.1</maven-release-plugin.version>
diff --git a/src/spotbugs/excludesFilter.xml b/src/spotbugs/excludesFilter.xml
index 6ddd604..5cd5e96 100644
--- a/src/spotbugs/excludesFilter.xml
+++ b/src/spotbugs/excludesFilter.xml
@@ -1,29 +1,38 @@
-<!--
- ~ The MIT License
- ~
- ~ Copyright (c) 2015, CloudBees, Inc.
- ~
- ~ Permission is hereby granted, free of charge, to any person obtaining a copy
- ~ of this software and associated documentation files (the "Software"), to deal
- ~ in the Software without restriction, including without limitation the rights
- ~ to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- ~ copies of the Software, and to permit persons to whom the Software is
- ~ furnished to do so, subject to the following conditions:
- ~
- ~ The above copyright notice and this permission notice shall be included in
- ~ all copies or substantial portions of the Software.
- ~
- ~ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- ~ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- ~ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- ~ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- ~ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- ~ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
- ~ THE SOFTWARE.
- -->
-
 <FindBugsFilter>
+  <!--
+    Exclusions in this section have been triaged and determined to be
+    false positives.
+  -->
+  <Match>
+    <Bug pattern="MS_MUTABLE_COLLECTION_PKGPROTECT" />
+    <Class name="hudson.plugins.logparser.LogParserConsts" />
+    <Or>
+      <Field name="LEGAL_STATUS" />
+      <Field name="STATUSES_WITH_SECTIONS_IN_LINK_FILES" />
+    </Or>
+  </Match>
+
+  <!--
+    Here lies technical debt. Exclusions in this section have not yet
+    been triaged. When working on this section, pick an exclusion to
+    triage, then:
+
+    - Add a @SuppressFBWarnings(value = "[...]", justification = "[...]")
+      annotation if it is a false positive.  Indicate the reason why
+      it is a false positive, then remove the exclusion from this
+      section.
+
+    - If it is not a false positive, fix the bug, then remove the
+      exclusion from this section.
+   -->
   <Match>
-    <Class name="~.*\.Messages"/>
+    <Bug pattern="DM_DEFAULT_ENCODING" />
+    <Or>
+      <Class name="hudson.plugins.logparser.LogParserParser" />
+      <Class name="hudson.plugins.logparser.LogParserResult" />
+      <Class name="hudson.plugins.logparser.LogParserUtils" />
+      <Class name="hudson.plugins.logparser.LogParserWriter" />
+      <Class name="hudson.plugins.logparser.ReadWriteTextFile" />
+    </Or>
   </Match>
 </FindBugsFilter>