Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code coverage (codecov) on PRs is broken #369

Open
jtnord opened this issue Aug 15, 2024 · 3 comments
Open

code coverage (codecov) on PRs is broken #369

jtnord opened this issue Aug 15, 2024 · 3 comments

Comments

@jtnord
Copy link
Member

jtnord commented Aug 15, 2024

Jenkins and plugins versions report

Per #368 (comment) and #368 (comment) the code coverage checks are using an obsolete baseline leading to changes in other PRs being included in reports for new PRs.

What Operating System are you using (both controller, and any agents involved in the problem)?

N/A

Reproduction steps

Take a look at the coverage report for #368 and observe the base commit is not the correct base commit.

https://app.codecov.io/gh/jenkinsci/oic-auth-plugin shows latest commit b7205f1 which is not the latest commit on master

upload job for master should succeed but is failing due to a lack of token.

Expected Results

code coverage is computed against the correct base for a plugin
latest known commit for code coverage on https://app.codecov.io/gh/jenkinsci/oic-auth-plugin matches the latest commit on master (subject to any delay in building the job which should be < 1 hr)

Actual Results

baseline is old
code coverage is being calculated against this old delta

Anything else?

No response

Are you interested in contributing a fix?

No response

@michael-doubez
Copy link
Contributor

It seems it stopped working 1 month ago. I'll have a look

@michael-doubez
Copy link
Contributor

Waiting for jenkins-infra/helpdesk#4267

@michael-doubez
Copy link
Contributor

@jtnord it seems I have lost the write access to the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants