Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree layout doesn't support nested parallel stages #216

Closed
stuartrowe opened this issue Feb 21, 2023 · 1 comment · Fixed by #233 or #285
Closed

Tree layout doesn't support nested parallel stages #216

stuartrowe opened this issue Feb 21, 2023 · 1 comment · Fixed by #233 or #285
Labels
bug Something isn't working

Comments

@stuartrowe
Copy link
Contributor

Jenkins and plugins versions report

Environment
Jenkins: 2.361.4
OS: Windows 11 - 10.0
Java: 11.0.17 - Eclipse Adoptium (OpenJDK 64-Bit Server VM)
---
ace-editor:1.1
apache-httpcomponents-client-4-api:4.5.13-138.v4e7d9a_7b_a_e61
bouncycastle-api:2.26
branch-api:2.1051.v9985666b_f6cc
caffeine-api:2.9.3-65.v6a_47d0f4d1fe
cloudbees-folder:6.758.vfd75d09eea_a_1
command-launcher:1.2
credentials:1189.vf61b_a_5e2f62e
credentials-binding:523.vd859a_4b_122e6
dark-theme:262.v0202a_4c8fb_6a
display-url-api:2.3.6
durable-task:500.v8927d9fd99d8
git:4.14.1
git-client:3.13.0
github:1.34.3
github-api:1.303-400.v35c2d8258028
github-branch-source:1696.v3a_7603564d04
instance-identity:116.vf8f487400980
ionicons-api:31.v4757b_6987003
jackson2-api:2.13.4.20221013-295.v8e29ea_354141
jakarta-activation-api:2.0.1-2
jakarta-mail-api:2.0.1-2
javax-activation-api:1.2.0-5
javax-mail-api:1.6.2-5
jaxb:2.3.7-1
jdk-tool:1.0
jjwt-api:0.11.5-77.v646c772fddb_0
jsch:0.1.55.61.va_e9ee26616e7
mailer:438.v02c7f0a_12fa_4
metrics:4.2.10-405.v60a_9cc74e923
okhttp-api:4.9.3-108.v0feda04578cf
pipeline-graph-analysis:195.v5812d95a_a_2f9
pipeline-graph-view:999999-SNAPSHOT (private-1abdd280-stuartr)
pipeline-groovy-lib:621.vb_44ce045b_582
pipeline-input-step:466.v6d0a_5df34f81
pipeline-model-api:2.2118.v31fd5b_9944b_5
pipeline-model-definition:2.2118.v31fd5b_9944b_5
pipeline-model-extensions:2.2118.v31fd5b_9944b_5
pipeline-stage-step:296.v5f6908f017a_5
pipeline-stage-tags-metadata:2.2118.v31fd5b_9944b_5
plain-credentials:139.ved2b_9cf7587b
scm-api:621.vda_a_b_055e58f7
script-security:1218.v39ca_7f7ed0a_c
snakeyaml-api:1.33-90.v80dcb_3814d35
ssh-credentials:305.v8f4381501156
sshd:3.236.ved5e1b_cb_50b_2
structs:324.va_f5d6774f3a_d
theme-manager:1.5
token-macro:321.vd7cc1f2a_52c8
trilead-api:2.84.v72119de229b_7
variant:59.vf075fe829ccb
workflow-api:1200.v8005c684b_a_c6
workflow-basic-steps:994.vd57e3ca_46d24
workflow-cps:3536.vb_8a_6628079d5
workflow-durable-task-step:1217.v38306d8fa_b_5c
workflow-job:1254.v3f64639b_11dd
workflow-multibranch:716.vc692a_e52371b_
workflow-scm-step:400.v6b_89a_1317c9a_
workflow-step-api:639.v6eca_cd8c04a_a_
workflow-support:839.v35e2736cfd5c

What Operating System are you using (both controller, and any agents involved in the problem)?

OS: Windows 11 - 10.0

Reproduction steps

This issue can be reproduced with the example pipeline below:

node {
    parallel([
        "A": {
            stage("Build") {
                echo("Build A")
            }
            stage("Test") {
                parallel([
                    "A1" : {
                       echo("Test A1")
                    },
                    "A2" : {
                       echo("Test A2")
                    }
                ])
            }
        },
        "B": {
            stage("Build") {
                echo("Build B")
            }
            stage("Test") {
                parallel([
                    "B1" : {
                       echo("Test B1")
                    },
                    "B2" : {
                       echo("Test B2")
                    }
                ])
            }
        }
    ])
}

Expected Results

The parallel branches for A1, A2 and B1, B2 should be nested under the Test stage of the parent A and B branches respectively. The pipeline steps view provided by the Pipeline: Supporting APIs Plugin correctly handles this:
image

Actual Results

The nested parallel branches are incorrectly shown as siblings of their parent parallel branch:
image

Anything else?

May be similar / duplicate of #51, but I believe that was created before the move to the tree layout and doesn't include the pipeline console view issue.

@stuartrowe stuartrowe added the bug Something isn't working label Feb 21, 2023
@timbrown5
Copy link
Contributor

I think this is related to #51 as the tree view uses the graph view as a basis.

@stuartrowe stuartrowe mentioned this issue Mar 2, 2023
9 tasks
@timja timja closed this as completed in #233 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants