Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kreport2krona does not check last line in the report #34

Open
JavierToledoAruba opened this issue Mar 29, 2021 · 2 comments
Open

kreport2krona does not check last line in the report #34

JavierToledoAruba opened this issue Mar 29, 2021 · 2 comments

Comments

@JavierToledoAruba
Copy link

JavierToledoAruba commented Mar 29, 2021

Hello everybody! I wanted to notify some problem with kreport2krona.py:

I have this report for a very simple in-silico metagenomic sample:

21.38 10203 10203 U 0 unclassified
78.62 37509 0 R 1 root
58.09 27715 0 R1 131567 cellular organisms
36.91 17612 0 D 2759 Eukaryota
36.91 17612 0 D1 33154 Opisthokonta
20.90 9974 0 K 4751 Fungi
20.90 9974 0 K1 451864 Dikarya
20.90 9974 0 P 4890 Ascomycota
20.90 9974 0 P1 716545 saccharomyceta
20.90 9974 0 P2 147537 Saccharomycotina
20.90 9974 0 C 4891 Saccharomycetes
20.90 9974 0 O 4892 Saccharomycetales
20.90 9974 0 F 4893 Saccharomycetaceae
20.90 9974 0 G 4930 Saccharomyces
20.90 9974 0 S 4932 Saccharomyces cerevisiae
20.90 9974 9974 S1 559292 Saccharomyces cerevisiae S288C
16.01 7638 0 K 33208 Metazoa
16.01 7638 0 K1 6072 Eumetazoa
16.01 7638 0 K2 33213 Bilateria
16.01 7638 0 K3 33511 Deuterostomia
16.01 7638 0 P 7711 Chordata
16.01 7638 0 P1 89593 Craniata
16.01 7638 0 P2 7742 Vertebrata
16.01 7638 0 P3 7776 Gnathostomata
16.01 7638 0 P4 117570 Teleostomi
16.01 7638 0 P5 117571 Euteleostomi
16.01 7638 0 P6 8287 Sarcopterygii
16.01 7638 0 P7 1338369 Dipnotetrapodomorpha
16.01 7638 0 P8 32523 Tetrapoda
16.01 7638 0 P9 32524 Amniota
16.01 7638 0 C 40674 Mammalia
16.01 7638 0 C1 32525 Theria
16.01 7638 0 C2 9347 Eutheria
16.01 7638 0 C3 1437010 Boreoeutheria
16.01 7638 0 C4 314146 Euarchontoglires
16.01 7638 0 O 9443 Primates
16.01 7638 0 O1 376913 Haplorrhini
16.01 7638 0 O2 314293 Simiiformes
16.01 7638 0 O3 9526 Catarrhini
16.01 7638 0 O4 314295 Hominoidea
16.01 7638 0 F 9604 Hominidae
16.01 7638 0 F1 207598 Homininae
16.01 7638 0 G 9605 Homo
16.01 7638 7638 S 9606 Homo sapiens
21.17 10103 0 D 2 Bacteria
21.17 10103 0 P 1224 Proteobacteria
21.17 10103 0 C 1236 Gammaproteobacteria
21.17 10103 0 O 72274 Pseudomonadales
21.17 10103 0 F 135621 Pseudomonadaceae
21.17 10103 0 G 286 Pseudomonas
21.17 10103 0 G1 136841 Pseudomonas aeruginosa group
21.17 10103 0 S 287 Pseudomonas aeruginosa
21.17 10103 10103 S1 208964 Pseudomonas aeruginosa PAO1
20.53 9794 0 D 10239 Viruses
20.53 9794 0 D1 35237 dsDNA viruses, no RNA stage
20.53 9794 0 O 548681 Herpesvirales
20.53 9794 0 F 10292 Herpesviridae
20.53 9794 0 F1 10293 Alphaherpesvirinae
20.53 9794 0 G 10294 Simplexvirus
20.53 9794 9794 S 10298 Human alphaherpesvirus 1

When I use kreport2krona, the krona file created is the following:

10203 Unclassified
0 k__Eukaryota
0 k__Eukaryota p__Ascomycota
0 k__Eukaryota p__Ascomycota c__Saccharomycetes
0 k__Eukaryota p__Ascomycota c__Saccharomycetes o__Saccharomycetales
0 k__Eukaryota p__Ascomycota c__Saccharomycetes o__Saccharomycetales f__Saccharomycetaceae
0 k__Eukaryota p__Ascomycota c__Saccharomycetes o__Saccharomycetales f__Saccharomycetaceae g__Saccharomyces
9974 k__Eukaryota p__Ascomycota c__Saccharomycetes o__Saccharomycetales f__Saccharomycetaceae g__Saccharomyces s__Saccharomyces_cerevisiae
0 k__Eukaryota p__Chordata
0 k__Eukaryota p__Chordata c__Mammalia
0 k__Eukaryota p__Chordata c__Mammalia o__Primates
0 k__Eukaryota p__Chordata c__Mammalia o__Primates f__Hominidae
0 k__Eukaryota p__Chordata c__Mammalia o__Primates f__Hominidae g__Homo
7638 k__Eukaryota p__Chordata c__Mammalia o__Primates f__Hominidae g__Homo s__Homo_sapiens
0 k__Bacteria
0 k__Bacteria p__Proteobacteria
0 k__Bacteria p__Proteobacteria c__Gammaproteobacteria
0 k__Bacteria p__Proteobacteria c__Gammaproteobacteria o__Pseudomonadales
0 k__Bacteria p__Proteobacteria c__Gammaproteobacteria o__Pseudomonadales f__Pseudomonadaceae
0 k__Bacteria p__Proteobacteria c__Gammaproteobacteria o__Pseudomonadales f__Pseudomonadaceae g__Pseudomonas
10103 k__Bacteria p__Proteobacteria c__Gammaproteobacteria o__Pseudomonadales f__Pseudomonadaceae g__Pseudomonas s__Pseudomonas_aeruginosa
0 k__Viruses
0 k__Viruses o__Herpesvirales
0 k__Viruses o__Herpesvirales f__Herpesviridae
0 k__Viruses o__Herpesvirales f__Herpesviridae g__Simplexvirus

(here you have both of the files)
Simple_sample.zip

If you compare both files, you'll notice that the last line in the report, corresponding to Human alphaherpesvirus 1, is not present in the krona file (therefore, not in the html created by krona). I've tried to fix this on my own, but no success so far. Maybe you can help me out here? Thank you for your attention!

@jenniferlu717
Copy link
Owner

thanks for letting me know! I'm going to take a look right now

@jenniferlu717
Copy link
Owner

I thinkk i uploaded a fix, but let me know if it doesnt work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants