-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the default styling of fieldset? #50
Comments
^ that works in Firefox. I didn't test cross browser. Maybe we put this in the main remedy stylesheet. Maybe we put it in suggestions. Let's think about it. |
I think another reason is that |
Or |
In Gecko, |
@dbaron Is fieldset super old?? Therefore underspecified and lacks interop? I'm testing |
Depends on your definition of "super old", I guess. I think it was introduced in HTML 4.0, which was 1997. It's certainly underspecified and lacks interop, though. |
I think the main reason people don't use fieldset very often is because its only useful if you want to add a legend (the design team usually has their own, non-semantic ideas about that) or disable the entire form with one attribute (not usually needed). |
The proposed styling makes The border is one of those outset (or inset?) borders in Firefox, and 2px wide in Chrome. It looks ... un-modern. Personally, I think something like just |
fieldset is used because it allows you to set a bunch of fields as enabled/disabled in one shot |
I've arrived here because of looking to disable a fieldset but not have the border so I agree with @frfancha . It may not have been the original design intention but being able to put a fieldset "around" a group of elements to disable/enable in one step looks useful. My (working in Chrome) example is around a ul which cannot be disabled and is not in a form - I was looking for the disabling and not the presentation aspects of fieldset; border: none and padding:0 seem to remove the visual side. |
@SGP57 Can I suggest that if you need an "invisible" fieldset like this, you set the CSS selector to: |
Just chiming into this conversation, as I just stumbled upon this. I run a large production app with Bootstrap 3, which, of course, has its own set of resets native to the framework. We use However, for some reason or another, we had to skip
Personally, I think we'd be better off with a new set of elements at this point to not break existing compatibility with sites that use <fieldgroup aria-describedby='#thing1'>
<h4 id='thing1'>Basic information</h4>
<!-- fields -->
</fieldgroup>
<!-- or -->
<fieldgroup aria-label="Basic information">
<h4>Basic information</h4>
<!-- fields -->
</fieldgroup> I mean, we have a bunch of HTML5 tags that have very specific use like But, for today, we use something like the following: fieldset {
border-bottom: 1px solid #eee;
margin-bottom: 21px;
padding-bottom: 10.5px;
position: relative;
padding: 0;
margin: 0;
border: 0;
min-width: 0;
} That seems to work well going back to IE8, though, of course, doesn't fully notify a user with a screen reader what those fields actually are, because |
I like the concept of the fieldset, but not fully supporting display flex is what makes me remove fieldset every time I use it. For some reason I still need to try it, google it and come in this thread over and over... |
I like the how the |
Why don't people use
<fieldset>
far more — instead of divs in their forms?Perhaps it's because
fieldset
comes with ugly default styling.Maybe we should remove it?
The text was updated successfully, but these errors were encountered: