Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

critic future- where is active development? - make it a project? #140

Open
mikedlr opened this issue Aug 30, 2019 · 1 comment
Open

critic future- where is active development? - make it a project? #140

mikedlr opened this issue Aug 30, 2019 · 1 comment

Comments

@mikedlr
Copy link

mikedlr commented Aug 30, 2019

I used critic some years ago and thought it was really great - answering a number of problems we had with the way Gerrit worked and supporting the way we wanted to work. Now I'm investigating code review tools again since GitHub PRs which we are using now just don't do a bunch of things right.

I thought that I'd have a look at critic again. Based on what I can see I guess it's not active any more so I will rule it out, but that makes me sad since it was great.

I wonder if it might be possible to open it up as a project to include other people? Piotr Iwaniuk seems to have done some more recent work?

Is there any other place where critic development is active?

In any case, thanks for all the great work. When I used it I loved it.

@jensl
Copy link
Owner

jensl commented Sep 2, 2019

Glad to hear you liked using Critic!

A bit of project status:

  • I'm not great as a project manager, or project maintainer, for sure.
  • Due to family situation (a child, to be specific) I don't have very much time or energy for Critic work.

There are essentially two versions of Critic. Let's call them "classic" and "2.0". Development of "classic" in my hands is indeed mostly dead, since I suck. I'd be very happy to hand that over to someone else, or some other management.

"2.0" is where my current hobby hacking goes. It's a pretty complete rewrite of the whole system. (It was never really intended to be that, but it ended up that way, since there's no project management here.)

Highlights:

  • Design modified to work better containerized (settings stored in database instead of file system, and divided somewhat into "micro-services".)
  • Backend implemented in Python 3.
  • Backend now simply exposes a REST API that covers all data/functionality.
  • Frontend implemented in react/redux with material-ui components/styling.

Due to no-one to collaborate with for much of the development, my work-flow (i.e. meaningful commits and reviewing) collapsed and so this work is on a branch with most of it in a single huge commit (https://critic-review.org/log?repository=critic&branch=mui). Again, I suck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants