Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension documentation not in sync with code #97

Open
rchl opened this issue Sep 5, 2015 · 1 comment
Open

Extension documentation not in sync with code #97

rchl opened this issue Sep 5, 2015 · 1 comment

Comments

@rchl
Copy link
Collaborator

rchl commented Sep 5, 2015

In https://github.com/jensl/critic/blob/master/src/tutorials/extensions-api.txt#L153 these APIs are listed:

|   Changeset getChangeset(string a, string b);
|   Changeset getChangeset(Commit a, Commit b);

But they don't seem to be implemented as far as I can see in https://github.com/jensl/critic/blob/master/src/library/js/v8/critic-git.js#L692

A bit of a shame because I wanted to use it. :)

@rchl
Copy link
Collaborator Author

rchl commented Sep 5, 2015

Ah, I can just pass an object with parent and child properties and it will do what I want. So the issue is in documentation being wrong only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant