Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn-rw-register: non complete response payload validation #57

Open
madtrick opened this issue Apr 6, 2023 · 1 comment
Open

txn-rw-register: non complete response payload validation #57

madtrick opened this issue Apr 6, 2023 · 1 comment

Comments

@madtrick
Copy link

madtrick commented Apr 6, 2023

Hi,

When working on the txn-rw-register workload I noticed that my responses to the txn operation weren't conformant to the protocol because I was leaving out some of the operations of the transaction. An example:

[2023-04-06T05:34:52.648Z]: "[recv][from:c6][type:txn][msg_id:1] {\"id\":5,\"src\":\"c6\",\"dest\":\"n0\",\"body\":{\"txn\":[[\"r\",8,null],[\"w\",8,1],[\"r\",9,null]],\"type\":\"txn\",\"msg_id\":1}}"
[2023-04-06T05:34:52.648Z]: "[send] {\"dest\":\"c6\",\"src\":\"n0\",\"body\":{\"msg_id\":1,\"type\":\"txn_ok\",\"txn\":[[\"r\",8,null]],\"in_reply_to\":1}}"

Int the example above, I replied to message 1 with only the "read" operation. However maelstrom reported that all was good at the end of the execution. Is this a bug or is the checker lenient?

@aphyr
Copy link
Contributor

aphyr commented Apr 6, 2023

Both, I suppose! Checker only cares about completion ops and actually ignores invocations altogether. Someone with lots of free time (presently, not me, haha) ought to add a pass to Elle which validates that input and output transactions have the same structure. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants