New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript type for rawBody doesn't align with APIGatewayProxyEventBase body #209

Open

LyndonHook opened this issue Jul 18, 2022 · 1 comment

Assignees

LyndonHook commented Jul 18, 2022

The REQUEST.rawBody is the same as the lambda event body which should be string | null but is defined as string in the type definition.

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/aws-lambda/trigger/api-gateway-proxy.d.ts#L117

https://github.com/jeremydaly/lambda-api/blob/main/index.d.ts#L146

Can it be updated to match? I'm happy to raise pull request.

The text was updated successfully, but these errors were encountered:

naorpeled self-assigned this

Collaborator

naorpeled commented Dec 20, 2022

Hey @LyndonHook,
thanks for opening this issue and sorry for the delayed response.

Feel free to open a PR that resolves this :)
If you'd like me to do so, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment