Datetime with precision not recognized when upgrading from 5.29.0 to 5.32.0 +

[rjgroller]

Hello,

I seem to have a case where a datetime with precision is not correctly being identified as a datetime. ActiveRecord was used for migrations only in this legacy project - Sequel is used in the code base and the db is Aurora MySQL. The code that breaks with this upgrade hasn't been touched in 4+ years.

Migration:

class AddLastActiveOnToResource < ActiveRecord::Migration[4.2]
  def up
    unless column_exists?(:resource, :lastActiveOn)
      add_column(:units, :lastActiveOn, :datetime, precision: 6)
    end
  end

  def down
    if column_exists?(:resource, :lastActiveOn)
      remove_column(:resource, :lastActiveOn)
    end
  end
end

Schema entry:

    t.datetime "lastActiveOn"

When I run:

schema = Resource.db.schema('resource')
last_active_on = schema.find { |name, _| name.to_s == 'lastActiveOn' }
puts "\nlastActiveOn schema:"
puts "#{last_active_on.inspect}"

5.29.0 (Passes)

lastActiveOn schema: [:lastActiveOn, {:primary_key=>false, :generated=>false, :allow_null=>true, :default=>nil, :db_type=>"datetime(6)", :type=>:datetime, :ruby_default=>nil}]

5.32.0 + (Fails)

lastActiveOn schema: [:lastActiveOn, {:primary_key=>false, :generated=>false, :allow_null=>true, :comment=>nil, :default=>nil, :db_type=>"datetime(6)", :type=>nil, :extra=>"", :ruby_default=>nil}]

Note that the :type field is :datetime in the passing case and nil in the failing case. All, timestamps and datetimes without precision continue to work in this project as expected.

It seems like this commit is related to this case and makes me think that it should still be correctly populating the type: 3c5036d

[jeremyevans]

Thank you for the report. I'll push a commit shortly to fix this.

[rjgroller]

Thanks @jeremyevans - appreciate the quick response!