-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NVD API request failures are occurring; retrying request for the n time #6515
Comments
Try increasing the delay. Also after you get the initial download successful - if you keep the data directory around you only have to download a small subset of the data (just the updated/new entries) so it'll be much faster/stable after the first download. |
Hi Jeremy, thank you.
but seems that problems persist. Any other advice? |
Hi, |
@tbattisti you appear to be using the internal API. No clue what other settings you are using or how your env is setup - so I have no advice. |
@wei-qiang use an API key, make sure the API key is valid, make sure you can hit the API from whatever machine is running ODC (use curl/wget). Increase the delay. Once you've downloaded the data the first - don't throw it away. Persist the data directory somehow. See https://jeremylong.github.io/DependencyCheck/data/cacheh2.html |
Hi @wei-qiang,
for temporary skip updates. |
NVD seems to be having API problems again today. |
Hi, The fact is I'm using this plugin in a CI/CD pipeline and it just burned nearly 30 minutes of credit before I realized the pipeline has still not finished (for reference, the whole pipeline takes under 5 minutes to complete). Maybe you could reduce the default timeout duration? |
It seems to be dead. |
I haven't been having any issues with the API as I have been keeping a cache/datafeed up-to-date. You can see the job running here: https://github.com/dependency-check/DependencyCheck_Builder/actions/runs/8357974490 Following either of these should help: |
I have the same problem now, and add that when testing with curl I actually get a 503 response. It is unclear for me if my API key is not valid or if this is the same for everybody
returns:
|
It's the same for everybody. The NVD API has been down since yesterday. They appear to have run out of money or something.
|
This was refreshed last night: https://dependency-check.github.io/DependencyCheck_Builder/ |
How do you actually get it to continue with stale data? It says it will, but then it doesn't.
|
Use |
I don't want no update though. I want it to try to update all sources, and then continue with what it's got. Like the warning implies is going to happen. The database was fully updated two days ago, and up-to-date on Sonatype and CISA thanks to overriding |
The error DependencyCheck/core/src/main/java/org/owasp/dependencycheck/Engine.java Lines 641 to 643 in 0e183da
|
You shouldn't need the |
That is not true. If I add |
All I'm saying is look at the code I linked. I'm not sure how it isn't true... Could be a bug... |
It is not logging this, so something you're not expecting must be happening. I'll go drop some debug logs on a new issue. |
Should this issue be used to request improvement of the retry message? It is not clearly or idiomatically worded. For example (if it means what I think it means):
…then fail if the last attempt fails. I assume that a |
anyone is seeing this exception: ConnectionClosedException: Connection closed by peer? |
+1 on improving the retry logic, there is a bug somewhere
I understand that the NVD api is undergoing maintenance but there should be better retry/timeout/failure flags to continue with whats in the database if updates fail instead of just hanging for hours. |
Hi, |
It seems, upgrading the open-vulnerability-clients fixed it for me. (The current version in dependency-check-maven:9.0.9 was 5.1.1)
|
@jesli96 nothing you did fixed anything. The NVD service was struggling heavily from Wednesday, but was mostly fine today. |
NVD API appears to be working okay again. Closing this ticket. |
I'm seeing the issue again. |
Same for me today.
|
Different root cause, see #6746 (comment) For this one, ODC itself needs to be released with a new version which everyone needs to upgrade to. |
Thank you! Looking forward to the new release then! |
Doesn't the 10.0.0 release fix this? From https://github.com/jeremylong/DependencyCheck/blob/main/CHANGELOG.md#version-1000-2024-07-01
|
@paul-redwood it fixed #6746, yes. That's why it's closed now. |
Hello, FYI I'm still having this issue with version 11.0.0 :
|
See #7178 - no need to resurrect old issues. |
Hi,
I'm having problems updating the database with the new CVEs.
The version is 9.0.9.
I'm using NVD api key.
Below the errors:
When i try to get informations with curl, no problems arise:
Is anyone else experiencing this problem?
The text was updated successfully, but these errors were encountered: