Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling unbind with undefined argument removes all listeners #28

Open
AndrewRayCode opened this issue Nov 5, 2014 · 2 comments
Open

Calling unbind with undefined argument removes all listeners #28

AndrewRayCode opened this issue Nov 5, 2014 · 2 comments

Comments

@AndrewRayCode
Copy link

Events.unbind( 'name', this.doesNotExist ); will remove ALL name events. Suggest checking arguments.length in the unbind function to prevent this behavior. Makes for some unexpected problems if you don't catch it.
@jeromeetienne
Copy link
Owner

seems a good idea. im super busy tho.

pull request welcomed

@vincent
Copy link

vincent commented Dec 19, 2014

Isn't it the same as #19, for which there's already a (not merged) PR #27 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vincent @AndrewRayCode @jeromeetienne