-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jesse docker image not support arm64 by default #480
Comments
Either when you build it that way, will it also work for x86 machines, or do we have to build a separate one ARM a separate one for x86 machines? |
im not expert on docker but docker hub support multi arch image via buildx or manifest, the python image that jesse built on it follow that approach btw. that way its easy for me to build arm64 image on my apple m2 machine it will be easy to build multi arch image using GitHub Actions and buildx. |
Thank you, that's very helpful. |
check it out https://docs.docker.com/build/ci/github-actions/multi-platform/ only thing need to figure out is how to make arch dynamic in /install_ta-lib.sh |
Other than that, I didn't know I could build Docker images with GitHub Actions. I was using a separate VPS for it, so this will save me money as well. |
@saleh-mir opened a PR for this: |
hi |
What did you run to get that? Shouldnt have to build a wheel for numpy, what is your OS, python version and system archtecture (x86, ARM)? |
docker image built only for amd64 and that make it run slow on apple silicon cpu , windows on arm or linux arm64.
I built the image but with change line 11 on docker_build_helpers/install_ta-lib.sh
to
&& ./configure --build=aarch64-unknown-linux-gnu --prefix=${INSTALL_LOC}/ \
and its works fine and the performance is good.
The text was updated successfully, but these errors were encountered: