Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jesse docker image not support arm64 by default #480

Open
abdulbasetbasher opened this issue Sep 23, 2024 · 8 comments
Open

Jesse docker image not support arm64 by default #480

abdulbasetbasher opened this issue Sep 23, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@abdulbasetbasher
Copy link

docker image built only for amd64 and that make it run slow on apple silicon cpu , windows on arm or linux arm64.

image

I built the image but with change line 11 on docker_build_helpers/install_ta-lib.sh

to && ./configure --build=aarch64-unknown-linux-gnu --prefix=${INSTALL_LOC}/ \

and its works fine and the performance is good.

@abdulbasetbasher abdulbasetbasher added the bug Something isn't working label Sep 23, 2024
@saleh-mir
Copy link
Member

Either when you build it that way, will it also work for x86 machines, or do we have to build a separate one ARM a separate one for x86 machines?

@abdulbasetbasher
Copy link
Author

abdulbasetbasher commented Sep 23, 2024

Either when you build it that way, will it also work for x86 machines, or do we have to build a separate one ARM a separate one for x86 machines?

im not expert on docker but docker hub support multi arch image via buildx or manifest, the python image that jesse built on it follow that approach btw.

that way its easy for me to build arm64 image on my apple m2 machine

it will be easy to build multi arch image using GitHub Actions and buildx.

@saleh-mir
Copy link
Member

Thank you, that's very helpful.

@abdulbasetbasher
Copy link
Author

abdulbasetbasher commented Sep 23, 2024

Thank you, that's very helpful.

check it out https://docs.docker.com/build/ci/github-actions/multi-platform/

only thing need to figure out is how to make arch dynamic in /install_ta-lib.sh

@saleh-mir
Copy link
Member

Other than that, I didn't know I could build Docker images with GitHub Actions. I was using a separate VPS for it, so this will save me money as well.

@antevis
Copy link

antevis commented Nov 4, 2024

@saleh-mir opened a PR for this:
#485

@rezarafigh
Copy link

hi
i have this issue in install of Jesse, do you know how to fix it:
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for numpy
Failed to build numpy
ERROR: ERROR: Failed to build installable wheels for some pyproject.toml based projects (numpy)

@mcleantom
Copy link

hi i have this issue in install of Jesse, do you know how to fix it: note: This error originates from a subprocess, and is likely not a problem with pip. ERROR: Failed building wheel for numpy Failed to build numpy ERROR: ERROR: Failed to build installable wheels for some pyproject.toml based projects (numpy)

What did you run to get that? Shouldnt have to build a wheel for numpy, what is your OS, python version and system archtecture (x86, ARM)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants
@antevis @abdulbasetbasher @mcleantom @saleh-mir @rezarafigh and others