-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage of external project resources #125
Comments
If you truly want to remove these then there needs to be merges to the TP SDK, last I tried the changes were not acceptable, hence my fork. Essentially a breaking change was made rendering a public property internal. Since then I have added a more fully defined reflection implementation around custom attributes |
I asked and the custom attribute reflection changes seem likely to be accepted, it still leaves the issue of an internal type being needed. I'll look at that after Ive done the custom attribute PR, it low priority for mw right now though. |
Ive tried to consolidate as much as possible with the upstream repo here: Theres a discrepancy between the way we use providedtypes and the runtimes use of of RunTimeType, as such theres no way to PR our changes that allow ProvidedRecords to function as the RunTimeType of the attribute necessary by the reflection runtime to create the CustomAttribute. We currently will hit this code: Due to all types used by the standard provided type code are being wrapped with |
This is being discussed here: fsprojects/FSharp.TypeProviders.SDK#291 eventually I hope... |
Describe the bug
There are 2 resources used in paket.dependencies as github urls. This is not desirable as we do not have control over those and they can be removed any time and will break project.
Expected behavior
If we use dependencies, it is better to relay on nuget packages which have much stricter removal rules.
The text was updated successfully, but these errors were encountered: