Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow headers size extend to maxRequestHeadersSize in http client #12439

Closed
wants to merge 14 commits into from
Closed

Allow headers size extend to maxRequestHeadersSize in http client #12439

wants to merge 14 commits into from

Conversation

shaoxt
Copy link
Contributor

@shaoxt shaoxt commented Oct 29, 2024 •
edited
Loading

Fixes #12436

Allow headers size extend to maxRequestHeadersSize in http client

@sbordet sbordet requested review from gregw and sbordet and removed request for gregw November 5, 2024 17:13
sbordet
sbordet requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please:

  1. Apply the review comments.
  2. Rebase these changes against branch jetty-12.1.x, and squash them in just 1 commit.
  3. Move the tests to HttpClientTest and actually call setMaxRequestHeadersSize() in the test so that we will test it is working.

I am probably make your changes part of a larger set of changes that improve the behavior of the current implementation.

Thanks!

jetty-core/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java Outdated Show resolved Hide resolved
jetty-core/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java Outdated Show resolved Hide resolved
@shaoxt
Copy link
Contributor Author

shaoxt commented Nov 7, 2024

Thanks for reviewing the PR. Created a new PR for required changes
#12499
For some reasons, the last commits I tried to squash them in 1 commit. but git said the commits from two different parents.

Can you please:

  1. Apply the review comments.
  2. Rebase these changes against branch jetty-12.1.x, and squash them in just 1 commit.
  3. Move the tests to HttpClientTest and actually call setMaxRequestHeadersSize() in the test so that we will test it is working.

I am probably make your changes part of a larger set of changes that improve the behavior of the current implementation.

Thanks!

@shaoxt shaoxt closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow headers size extend to maxRequestHeadersSize in http client
2 participants
@shaoxt @sbordet