Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No hot deployment when replacing war-file #12543

Open
lglowania opened this issue Nov 15, 2024 · 5 comments
Open

No hot deployment when replacing war-file #12543

lglowania opened this issue Nov 15, 2024 · 5 comments
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@lglowania
Copy link

Jetty version(s)
12.0.15

Jetty Environment
ee10

Java version/vendor (use: java -version)
openjdk version "21.0.5" 2024-10-15 LTS

OS type/version
Debian Bookworm

Description
In our setup we copy war-archives to our production-system to deploy new versions of our software.
With Jetty 11 the new war-archive was detected and the context was redeployed. Since the upgrade to Jetty 12.0.10, i always have to touch the context's virtual-host-xml-file to trigger redeployment.

How to reproduce?
Create a webapp with the following structure in the webapps folder and enable the ee10-deploy-module.

webapps/my-webapp.xml
webapps/my-webapp.war

The webapp is only redeployed when my-webapp.xml is touched but not when my-webapp.war ist touched.

@lglowania lglowania added the Bug For general bugs on Jetty side label Nov 15, 2024
@joakime
Copy link
Contributor

joakime commented Nov 15, 2024

Hmm.
Your report does indeed look like a regression.
Do you also have a webapps/my-webapp.properties file? (usually used to specify the environment to deploy to)

@lglowania
Copy link
Author

No, i have no my-webapp.properties-file.

@janbartel
Copy link
Contributor

@gregw ISTR a conversation where we said that in jetty-12 if a .war file changed that was deployed via a .xml file that the .xml file would need to be touched to cause a redeploy. Can you confirm that? If so, then we need to update our documentation because that isn't clear in jetty-12.

@gregw
Copy link
Contributor

gregw commented Nov 19, 2024

@janbartel I don't recall such a conversation. But I'm not opposed to such a change. Note we probably should not change too much prior the redesign we want to do on the deployer.

@lglowania Is this a big issue for you?

@lglowania
Copy link
Author

It's not a big issue, i could touch the xml-file in the deploy-script. But instead of just copying the war-archive, the deploy-script would have to decide if a xml-file needs to be touched.

In my opinion the default jetty-behaviour should be redeployment when a new war-archive is detected. I think all application-servers that i got to know in the past behaved like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
Status: No status
Development

No branches or pull requests

4 participants