Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring hcl specifications #140

Open
jeroenrinzema opened this issue Oct 1, 2020 · 0 comments
Open

Refactoring hcl specifications #140

jeroenrinzema opened this issue Oct 1, 2020 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jeroenrinzema
Copy link
Contributor

The HCL specification parser contains a lot of code duplications. Interfaces should be created to simplify the parsing of intermediate HCL files. The following functions could most likely be simplified:

ParseIntermediateInputParameterMap
ParseIntermediateNestedParameterMap
ParseIntermediateRepeatedParameterMap
ParseIntermediateCallParameterMap
ParseIntermediateParameterMap

semaphore/pkg/providers/hcl/specs.go

Lines 16 to 20 in 7889d18

/**
* TODO: this file has to be refactored to avoid code duplication and
* type casting. A lot of code duplication is aroundnested and repeated parameter
* maps. Interfaces have to be created for these types to allow to reuse implementations.
*/

@jeroenrinzema jeroenrinzema added enhancement New feature or request help wanted Extra attention is needed hacktoberfest labels Oct 1, 2020
@Alma-media Alma-media mentioned this issue Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@veger @jeroenrinzema