Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External dependency (video.js) tries to load Google Analytics #145

Open
founderio opened this issue Jan 24, 2017 · 1 comment
Open

External dependency (video.js) tries to load Google Analytics #145

founderio opened this issue Jan 24, 2017 · 1 comment

Comments

@founderio
Copy link

founderio commented Jan 24, 2017

The video.js that is use in the video stream window is included from //vjs.zencdn.net/4.4/video.js (See dist/videoPlayer.html).
This version seems to try an load a google analytics plugin (well, I blocked it, but still..), e.g. using the following URL:

http://www.google-analytics.com/__utm.gif?utmwv=5.4.2&utmac=UA-16505296-2&utmn=1&utmhn=oliver-htpc&utmsr=3440x1237&utmul=en-us&utmr=http%3A%2F%2Foliver-htpc%3A8080%2FvideoPlayer.html%3Fplayer%3Dhtml5%26src%3Dvfs%2F%2F[FULL PATH TO VIDEO FILE HERE]&utmp=oliver-htpc%2FvideoPlayer.html&utmcc=__utma%3D1.6187846711.1.1.1.1%3B&utme=8(vjsv)9(v4.4.3)

(See vjs.zencdn.net/4.4/video.js, Line 138, for the code that does this)

That URL includes the full URL used, which includes the path to the file being streamed, which is HIGHLY unattractive for any site, let alone a web interface accessed via local network.

Side note: Even if only external resources are loaded, there is still the referrer-URL...
Would it not be better to distribute the required *.js with chorus? (Without that Analytics-Part!) I can also imagine that the video streaming will horribly fail if I try to access Chorus without an internet connection..

Using Chorus 0.3.10

EDIT: Huh, I just read that part about chorus being replaced with chorus 2. I'll leave this here anyways.

@jez500
Copy link
Owner

jez500 commented Jan 25, 2017

Added to the todo list for Chorus2
xbmc/chorus2#219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants