Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-nil false positive #28

Open
graingert opened this issue Jul 31, 2017 · 0 comments
Open

no-nil false positive #28

graingert opened this issue Jul 31, 2017 · 0 comments

Comments

@graingert
Copy link
Collaborator

graingert commented Jul 31, 2017

 switch (ham) {
    case "spam": return 3;
    case blockTypes.skew:
    default: return 4;
  }

should pass

same with:

if (foo) {
    return 3;
} else {
    return 4;
}

I've made a PR to fix eslint-plugin-better's explicit-return rule: idmitriev/eslint-plugin-better#3 using the consistent-return rule from eslint core

@graingert graingert changed the title no-nill false positive no-nil false positive Jul 31, 2017
graingert added a commit to graingert/eslint-plugin-fp that referenced this issue Jul 31, 2017
Allows rule users to use a slower, but more accurate must-return rule:

eg, idmitriev/eslint-plugin-better#3
graingert added a commit to graingert/eslint-plugin-fp that referenced this issue Aug 3, 2017
Allows rule users to use a slower, but more accurate must-return rule:

eg, idmitriev/eslint-plugin-better#3
graingert added a commit to graingert/eslint-plugin-fp that referenced this issue Aug 3, 2017
Allows rule users to use a slower, but more accurate must-return rule:

eg, idmitriev/eslint-plugin-better#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant