Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ansible/artifactory] support for subdomains in Nginx (for docker repositories) #353

Open
bbaassssiiee opened this issue Dec 8, 2023 · 2 comments · May be fixed by #359
Open

[ansible/artifactory] support for subdomains in Nginx (for docker repositories) #353

bbaassssiiee opened this issue Dec 8, 2023 · 2 comments · May be fixed by #359
Labels
enhancement New feature or request

Comments

@bbaassssiiee
Copy link
Contributor

bbaassssiiee commented Dec 8, 2023 •
edited
Loading

Is this a request for help?:

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Which installer:
Ansible

Which product and version (eg: ansible & collection version - 7.24.2):
Artifactory

Which operating system and version(eg: ubuntu & version - 20.4):
All

Which product license (Enterprise/Pro):
Enterprise

JFrog support reference (if already raised with support team):
#280332

What happened:
There is a reverse proxy config for Docker which is not implemented in the installer.
It can be generated with the UI:
/ui/admin/artifactory/configuration/reverse_proxy

What you expected to happen:
Config managed

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:
@chukka chukka added the enhancement New feature or request label Dec 11, 2023
@bbaassssiiee
Copy link
Contributor Author

bbaassssiiee commented Dec 21, 2023 •
edited
Loading

There is some config for it, this should be set artifactory_docker_registry_subdomain: true.
But when we set it we get an invalid Nginx config:

# nginx -t
nginx: [emerg] unknown "repo" variable
nginx: configuration file /etc/nginx/nginx.conf test failed

The Nginx config seems incomplete for this. If you generate it with the UI the server_name config starts with server_name ~(?<repo>.+)\..

Will create a patch

@bbaassssiiee bbaassssiiee linked a pull request Dec 21, 2023 that will close this issue
Open
3 tasks
@bbaassssiiee
Copy link
Contributor Author

bbaassssiiee commented Jan 8, 2024 •
edited
Loading

There is code in the master branch, but it is not working. PR #359 fixes this with 4 lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@chukka @bbaassssiiee