Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current working directory as parameter in Upload Spec Schema #196

Open
newrdb15 opened this issue Mar 29, 2023 · 0 comments
Open

Add current working directory as parameter in Upload Spec Schema #196

newrdb15 opened this issue Mar 29, 2023 · 0 comments
Labels
feature request New feature or request

Comments

@newrdb15
Copy link

Problem Background:
It's a shame that JFrog dropped the "**" search pattern and just had to work with "pattern" & "recursive" parameters to replicate old
legacy patterns(deprecated) feature.
This causes multiple issues when the current working directory is unstable OR if there is a need to work with different source directories.

This issue was not a problem to task "Artifactory Generic Deploy configuration" under Upload by "legacy patterns(deprecated)",
since we can use ** search pattern to deploy artifacts to designated directory of the target repository, maintaining the original relative path for each file.

Here's the problem:
Upon introducing Upload Spec schema, we have to only rely on both "pattern" & "recursive" parameter in order to emulate the same feature "maintaining the original relative path".
In use case such as working with multiple source directories, you have to move every artifacts to one single source directory in order to still maintain the original relative path without uploading the unnecessary subfolders.

Another use-case scenario would be, if there is change in current working directory.
There is always a dependency on wherever the current directory of task 'Artifactory Generic Deploy configuration' is pointed.
In this case, we would always need to adjust tasks that will copy all the artifacts to its appropriate directory.

If we do it like in this example:
"pattern": "${bamboo.build.working.directory}/myRelativeFolder/**",

in this scenario,
${bamboo.build.working.directory} = C:\Program Files\stuffs needed\file1\file2\file3
the uploaded artifacts would include these all these layers of folder, instead of only uploading myRelativeFolder and its subdirectories.

Proposed solution:
Maybe if we could add a new parameter called 'directory' like this:
"directory": "${bamboo.build.working.directory}",
"pattern": "myRelativeFolder/*",
"flat": "false",
"recursive": "true",

In this particular scenario, we could still manipulate the pattern to include the targeted folder & its subdirectories for artifacts upload and at the same time,
we can point a SPECIFIC source directory to get the artifacts ready for upload.

Thanks & Best Regards,

Royce

@newrdb15 newrdb15 added the feature request New feature or request label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant