Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[artifactory-ha] stateful set spec.serviceName should match the service created #1329

Closed

Conversation

kpirateone
Copy link
Contributor

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:
currently the service generated from artifactory service creates a service with name: artifactory-ha.fullname. the artifactory-node-statefulset.yaml creates a spec.serviceName as artifactory-ha.node.name. the service specified in the statefulset needs to align, particularly when addressing pods directly in kubernetes DNS : https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/

this pr changes the service creation to have the same name as specified in the node statefulset spec.serviceName

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
none

Special notes for your reviewer:

@eldada @rimusz @danielezer

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@chukka
@kpirateone
You can retrigger this bot by commenting recheckcla in this Pull Request

@kpirateone kpirateone changed the title artifactory-ha stateful set spec.serviceName should match the service created [artifactory-ha] stateful set spec.serviceName should match the service created Jan 5, 2021
@kpirateone
Copy link
Contributor Author

recheckcla

@gitta-jfrog
Copy link
Collaborator

We decided not to implement this change as this might have impact on our current deployments.
In addition, the node sts should not be used anymore as only primary sts is in use.

@gitta-jfrog gitta-jfrog closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants