Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[artifactory] Fix deprecated api ingress.yaml #1611

Closed
wants to merge 5 commits into from

Conversation

hansendiku
Copy link

@hansendiku hansendiku commented Apr 6, 2022

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:
This PR fixes a deprecated api check.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1407

Special notes for your reviewer:
#1407 was closed and was said to be fixed but looks like the bug still existed in the master branch.

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@hansendiku hansendiku changed the title Update ingress.yaml [artifactory] Fix deprecated api ingress.yaml Apr 6, 2022
@hansendiku
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@hansendiku
Copy link
Author

hansendiku commented Apr 6, 2022

I have read the CLA Document and I hereby sign the CLA

@hansendiku hansendiku marked this pull request as ready for review April 6, 2022 14:04
@oumkale
Copy link
Member

oumkale commented Aug 2, 2024

Hi @hansendiku ,

Kudos to you, Thank you so much for this PR.

We have released this in Artifactory version 7.52.1 and 7.56.0.

@oumkale oumkale closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated apiVersion for Ingress
2 participants