Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[artifactory] [artifactory-ha] Support Openshift helm install #1744

Closed
wants to merge 2 commits into from

Conversation

flouis1
Copy link

@flouis1 flouis1 commented Mar 29, 2023

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [] Chart Version bumped
  • [] CHANGELOG.md updated
  • [] Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:
Move securitycontext to container level:

  • Need to be set securitycontext at container level for openshift
  • Set security context at pod level will be no more possible on gke 1.25
    Add fixes on nginx to work with openshift

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

Signed-off-by: Fabien LOUIS <[email protected]>
@chukka
Copy link
Collaborator

chukka commented Jan 24, 2024

Supported via #1855

@chukka chukka closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants