Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jfrog-platform] 10.13.0 release #1777

Merged
merged 1 commit into from
Jun 4, 2023
Merged

[jfrog-platform] 10.13.0 release #1777

merged 1 commit into from
Jun 4, 2023

Conversation

chukka
Copy link
Collaborator

@chukka chukka commented Jun 4, 2023

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@misse
Copy link

misse commented Jun 26, 2023

Hi @chukka - since {{- if .Values.rabbitmq.enabled }} was removed we can no longer use the jfrog-platform helm chart to deploy artifactory (without any other jfrog application).

The migration hook will run even though we don't have rabbitMQ running and then fail, halting the deployment. Can the conditional be re-added or is there another solution so that we don't have to deploy rabbitmq?

@misse
Copy link

misse commented Jun 26, 2023

We're currently using this workaround successfully.

 rabbitmq:
    enabled: false
    migration:
      enabled: false
    rabbitmqUpgradeReady:
      - fake: arg
 

@chukka chukka deleted the jp-10.13.0 branch July 1, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants