Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless Values definition maxOpenConnections #1817

Closed
Amir-Wollman opened this issue Sep 12, 2023 · 1 comment
Closed

Useless Values definition maxOpenConnections #1817

Amir-Wollman opened this issue Sep 12, 2023 · 1 comment

Comments

@Amir-Wollman
Copy link

Unless I'm missing something, it would seem as though Values.yaml in artifactory chart defines value maxOpenConnections in database, tomcat and nginx.

However, there are no consumers of it in the templates themselves hence these values are not in use.

search results in code search:
https://github.com/search?q=repo%3Ajfrog%2Fcharts%20maxOpenConnection&type=code

Chart location:
https://github.com/jfrog/charts/tree/721428f2f1b4e1c35940cd4bf71f712e954fd902/stable/artifactory

@Amir-Wollman
Copy link
Author

NVM - I see that these are included as a templated values file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant