Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xray] add defaultRetentionDaysForIndexedRepo support #1833

Closed
wants to merge 1 commit into from

Conversation

gregoryboue
Copy link

@gregoryboue gregoryboue commented Oct 19, 2023

PR Checklist

  • Chart Version bumped
  • CHANGELOG.md updated
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:

Currently the Xray indexing default retention period can be defined in Xray System yaml with server.repo.defaultRetentionDaysForIndexedRepo settings.

If we want to configure this settings, we have to override xray system yaml (see systemYamlOverride), so it would be great to be able to configure this setting via a value in the chart's values.yaml file.

Which issue this PR fixes : fixes #1832

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@gregoryboue
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@gregoryboue
Copy link
Author

Is there anyone to review ?

@rahulsadanandan
Copy link
Collaborator

@gregoryboue Thanks for the PR. We will include this change in one of the upcoming releases.

@gregoryboue
Copy link
Author

@gregoryboue Thanks for the PR. We will include this change in one of the upcoming releases.

Hi, do you have any information about the release date ?

@gregoryboue
Copy link
Author

@rahulsadanandan , is this PR will be merged ?

@gregoryboue
Copy link
Author

@rahulsadanandan any news ?

@rahulsadanandan
Copy link
Collaborator

@gregoryboue

We're exploring the concept of structured system YAML as part of another PR (#1842). This method enables us to modify individual system YAML parameters without the need to supply the entire system YAML block.

@gregoryboue
Copy link
Author

@rahulsadanandan Thanks for the answer, it would be a very useful feature for us, i will waiting for it.

The ETA is for Q1 2024, do you have any precision about the month ?

@rahulsadanandan
Copy link
Collaborator

@gregoryboue Recently have merged a feature (#1842) that allows overriding the system YAML with the extraSystemYaml section. The entries specified under ‘xray.extraSystemYaml’ will be merged with files/system.yaml to generate the final system.yaml.
This change is available from Xray version 103.95.x onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Xray] Add ability to configure defaultRetentionDaysForIndexedRepo for Xray
3 participants