Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use POST request for federation livenessProbe #1847

Closed
wants to merge 3 commits into from

Conversation

NiklasRosenstein
Copy link

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:

It appears the /rtfs/sync/ping endpoint must be hit with a POST request instead of a GET request.

2023-12-07T15:11:24.336Z [jfrtfs] [ERROR] [               ] [.r.r.GlobalExceptionHandler:27] [http-nio-8085-exec-7] - Caught an error - Request method 'GET' is not supported
$ curl localhost:8085/rtfs/sync/ping
{"status":400,"message":"Request method 'GET' is not supported","traceId":"traceId"}

$ curl -XPOST localhost:8085/rtfs/sync/ping
{"status":200,"message":"PONG","traceId":"Take trace id"}

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@NiklasRosenstein NiklasRosenstein changed the title Using POST for federation livenessProbe Use POST request for federation livenessProbe Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@NiklasRosenstein
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@NiklasRosenstein
Copy link
Author

recheck

@NiklasRosenstein
Copy link
Author

Seems this is also needed for startupProbe, and the path appears incorrect as well (/artifactory/system/rtfs/ping instead of /rtfs/ping)

@eldada
Copy link
Contributor

eldada commented Dec 10, 2023

Hi @NiklasRosenstein . Thank you for this PR, but this service is actually not production ready and should not even be enabled.
The current federation functionality still runs in Artifactory.
Simply disable this service (federation.enabled=false) and ignore it.
The probes will be replaced with formal liveness and readiness as in other services when this service comes out officially.
I'm closing this PR for now. Let us know if you require any further assistance.

@eldada eldada closed this Dec 10, 2023
@NiklasRosenstein
Copy link
Author

Gotcha, thanks @eldada! I'm early into getting Artifactory set up and mistakenly assumed this service needs to run for Access Federation to work, although I had not tried it without yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants