Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[artifactory-ha] Fix missing volume on member nodes when using gcpServiceAccount.customSecretName #1878

Conversation

agunnerson-elastic
Copy link

Previously, only the volumeMount was created, but not the volume itself. This affected only member nodes, not primary nodes.

Fixes: #1873

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated
  • Title of the PR starts with chart name (e.g. [artifactory])

…viceAccount.customSecretName

Previously, only the volumeMount was created, but not the volume itself.
This affected only member nodes, not primary nodes.

Fixes: jfrog#1873

Signed-off-by: Andrew Gunnerson <[email protected]>
Copy link

github-actions bot commented May 3, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@agunnerson-elastic
Copy link
Author

^^ I'm waiting to get approval from my employer for signing the CLA. I'll post here once I get an update on that.

@oumkale oumkale requested review from chukka and oumkale May 7, 2024 05:12
@oumkale
Copy link
Member

oumkale commented May 7, 2024

Hi @agunnerson-elastic,

Thank you for your PR, we have already taken this internally and it will be released in upcoming release 7.84.x

Will keep you updated

@oumkale
Copy link
Member

oumkale commented May 16, 2024

Hi @agunnerson-elastic,

We really appreciate your efforts and are happy to inform you that your changes have been taken internally and released in 107.84.10

@oumkale oumkale closed this May 16, 2024
@agunnerson-elastic agunnerson-elastic deleted the member-statefulset-gcpcreds branch May 16, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StatefulSet artifactory-ha-jfrog-deployme-artifactory-ha-member failed. Not found: "gcpcreds-json"
2 participants