Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't fullname be used for the new artifactory-unified-secret? #1882

Closed
baselbmz opened this issue May 14, 2024 · 3 comments
Closed

Shouldn't fullname be used for the new artifactory-unified-secret? #1882

baselbmz opened this issue May 14, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@baselbmz
Copy link

I have noticed that in the stable/artifactory/templates/artifactory-unified-secret.yaml we are using name instead of fullname.

  name: {{ template "artifactory.name" . }}-unified-secret

I was wondering if fullname should have been used here? or is there a good reason for using name instead?

I have 2 instances of artifactory installed on the same namesapce, and while doing an upgrade, I got a conflict because both releases are trying to create the same object.

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
This is a question at the moment, it could be seen as a BUG REPORT if the chart was supposed to support 2 releases on the same namespace

Version of Helm and Kubernetes:
Kubernetes: v1.28.7-gke.1226000
Helm: v3.14.4

Which chart:
jfrog/artifactory --version 107.84.10

Which product license (Enterprise/Pro/oss):
oss

JFrog support reference (if already raised with support team):
N/A

What happened:
2 helm releases on the same namespace fight over the object artifactory-unified-secret. We use fullnameOverride to avoid such thing, but this is not used for this object :(

What you expected to happen:
if the chart was supposed to support 2 releases on the same namespace then fullname should be used for artifactory-unified-secret

How to reproduce it (as minimally and precisely as possible):
try to deploy 2 releases on the same namespace while using fullnameOverride (but not using nameOverride)

Anything else we need to know:
A work around could be to use nameOverride

@baselbmz baselbmz changed the title Shouldn't fullname be used for the new artifactory-unified-secret Shouldn't fullname be used for the new artifactory-unified-secret? May 14, 2024
@oumkale
Copy link
Member

oumkale commented May 15, 2024

Hi @baselbmz,

Thank you for taking this point, we will be taking this up internally and It will be fixed in future 7.84.x release

@chukka chukka added bug Something isn't working waiting-for-public-release labels May 16, 2024
@chukka chukka closed this as completed May 17, 2024
@chukka
Copy link
Collaborator

chukka commented May 17, 2024

@baselbmz Please try 107.84.11 chart for the fix and share feedback

@baselbmz
Copy link
Author

Thanks @chukka, we have tested the new release and the issue got fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants