[jfrog-platform] Typo to get fourth parameter for setupPostgres.sh #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the CHART_NAME is either the value of the variable if defined, otherwise '4'. It would be better to be the fourth parameter of the script if not defined.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks @neolutin, Acknowledging, will take this. |
chukka
added a commit
that referenced
this pull request
Oct 8, 2024
…1922) * Typo to get fourth parameter for setupPostgres.sh Currently the CHART_NAME is either the value of the variable if defined, otherwise '4'. It would be better to be the fourth parameter of the script if not defined. * Bumping version --------- Co-authored-by: Ram Mohan Rao Chukka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory])What this PR does / why we need it:
To be able to use the setup DB script manually, the parameters should be correctly mapped.
Which issue this PR fixes:
In ./stable/jfrog-platform/files/setupPostgres.sh, the CHART_NAME is either the value of the variable if defined, otherwise '4'. It would be better to be the fourth parameter of the script if not defined.