Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xray]Added support for service account annotations #1841

Merged
merged 2 commits into from
Oct 1, 2024
Merged

[xray]Added support for service account annotations #1841

merged 2 commits into from
Oct 1, 2024

Conversation

evanshoshan
Copy link

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [x ] Chart Version bumped
  • [x ] CHANGELOG.md updated
  • [ x] Variables and other changes are documented in the README.md
  • [x ] Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:

This PR allows for the configuring of service account annotations.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited
Loading

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

0 out of 2 committers have signed the CLA.
❌ @evan Shoshan
❌ @megha1906
Evan Shoshan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@evanshoshan
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@evanshoshan
Copy link
Author

recheck

@evanshoshan
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@rhys96
Copy link
Contributor

rhys96 commented Jul 1, 2024

This would be very helpful, I'm having to create my own Service Account to add annotations. Is anyone from JFrog able to give an update?

@megha1906
Copy link
Collaborator

@evanshoshan Thanks for the PR. We will check this internally and will fix this in the upcoming versions of Xray.
cc @rahulsadanandan

@megha1906 megha1906 changed the base branch from master to xray-3.105.x October 1, 2024 07:51
@megha1906 megha1906 merged commit 89c9bdf into jfrog:xray-3.105.x Oct 1, 2024
1 check failed
@megha1906
Copy link
Collaborator

HI @evanshoshan ,we will be releasing this change in Xray version 3.105.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abedmohammed77 abedmohammed77 abedmohammed77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evanshoshan @rhys96 @megha1906 @abedmohammed77