Reduce the amount of duplicate logging when using kubernetes agents #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Only the logging of the build publish command will get duplicated on kubernetes agents
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
janssk1
force-pushed
the
reduce-duplicate-logging
branch
from
9e572ab
to
89116d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the plugin on kubernetes based agents, all logs are duplicated.
This is introduced by https://github.com/jfrog/jenkins-jfrog-plugin/pull/63/files, where custom stdout handling was introduced to be able to extract the build info URL.
However, this does not work well with kubernetes agents. When the launcher provided by the kubernetes agent detects a custom stdout in the procstarter, it automatically does its own teeing, causing duplicate logs. Not sure if this is a bug in the kubernetes agent
This PR does not fix the problem, but reduces it's impact. Stdout tweaking is only done for the build publish command. Other commands (like eg mvn build) are untouched.
More details in #74