Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JFrogNpm@1 Task to Use Supported Node Version in Azure DevOps Pipelines #512

Closed
ashokm opened this issue Oct 25, 2024 · 9 comments
Closed
Labels
question Further information is requested

Comments

@ashokm
Copy link

ashokm commented Oct 25, 2024

We are receiving the following warning in our Azure DevOps pipelines when using the JFrogNpm@1 task:

##[warning]Task 'JFrog npm' version 1 (JFrogNpm@1) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

This issue seems similar to aws-toolkit-azure-devops#566, where upgrading to a current Node.js version is recommended to ensure continued support and security compliance.

As Node 10 is end-of-life, can you provide an update on when the task will be updated to use a supported Node.js version, in line with Microsoft’s Node upgrade guidance?

@ashokm ashokm added the question Further information is requested label Oct 25, 2024
@TobiasBreuer
Copy link

Please note that this is not limited to the JFrogNpm Task but e.g. also affects the ArtifactoryDocker task for example

Task 'Artifactory Docker' version 1 (ArtifactoryDocker@1) is dependent on a Node version (10) that is end-of-life....

@owen-delaney-admiral
Copy link

Also seeing it for JFrogPip@1, JFrogPublishBuildInfo@1 & JFrogBuildScan@1 tasks

@philippk80
Copy link

JFrogDotnetCore (1.10.1) too

@PratMoha
Copy link

ArtifactoryGenericDownload@1, ArtifactoryNuGet@2 are also affected since last week.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Nov 5, 2024

Dear all,
Following the requests here, we released version 2.10.3, which upgrade the tasks Node version from 10 to 16. @johnpp143 however reports in #517 that this change causes failures in older pipeline agents.
We'd love to get your insights and ideas about the best approach forward.

@d4nuu8
Copy link

d4nuu8 commented Nov 5, 2024

Node 16? This is EOL since September, 11th 2023.

@johnpp143
Copy link

@eyalbe4 According to migration document, https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/migrateNode16.md,
globally node v20 is supported for the task runner. If users have older version of azure agents, then there is a possibility that version 16 of node task runner will not be supported. Since this update affects all versions of the extension and not only the released version, i think if we can update the execution node like below, it would still support users with old azure build agents, while the newer versions will pick up Node16/20.
"execution": {
"Node10": {
"target": "bash.js",
"argumentFormat": ""
},
"Node16": {
"target": "bash.js",
"argumentFormat": ""
}
}

@eyalbe4
Copy link
Contributor

eyalbe4 commented Nov 6, 2024

Thanks for suggesting the solution @johnpp143 and thanks for contributing the fix @hanankem - #518.
Version 2.10.4 is now released.

@ashokm
Copy link
Author

ashokm commented Nov 6, 2024

LGTM with tasks running with the JFrog marketplace extension version 2.10.4.

Before:

Downloading task: JFrogNpm (1.10.1)
##[warning]Task 'JFrog npm' version 1 (JFrogNpm@1) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

Now (no warnings are shown and our pipelines run as expected):

Downloading task: JFrogNpm (1.10.4)

Thanks!

@ashokm ashokm closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

8 participants