Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Shadows in Dark Theme don't work. #3886

Open
gobijan opened this issue Aug 29, 2024 · 1 comment
Open

Proposal: Shadows in Dark Theme don't work. #3886

gobijan opened this issue Aug 29, 2024 · 1 comment

Comments

@gobijan
Copy link

gobijan commented Aug 29, 2024

This is about Bulma.

Overview of the problem

This is about the Bulma CSS framework

I'm using Bulma 1.0.2

Description

The shadow design for cards and boxes etc. doesn't look good in Dark Mode
CleanShot 2024-08-29 at 14 33 53

In order to keep the high visual quality of the framework we should adjust this behaviour by providing a different dark mode default.
See here for examples of efficient Dark Mode Design: https://medium.com/@tundehercules/designing-effective-dark-mode-interfaces-17f38ecea2e9

CleanShot 2024-08-29 at 14 33 38

In case this get's accepted I will create a PR

@gobijan gobijan changed the title Shadows in Dark Theme look terrible Shadows in Dark Theme don't work. Aug 29, 2024
@gobijan gobijan changed the title Shadows in Dark Theme don't work. Proposal: Shadows in Dark Theme don't work. Aug 29, 2024
@gobijan
Copy link
Author

gobijan commented Aug 30, 2024

This works for me as a sane default.

/* Dark mode styles */
[data-theme="dark"] .box,
.theme-dark .box {
  --bulma-box-shadow: none;
}

/* Alternative using media query for system preference */
@media (prefers-color-scheme: dark) {
  .box {
    --bulma-box-shadow: none;
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant