-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make app buildable for new devs #93
Comments
Yeah, that is a route we can go down. I've been trying to research how to properly do this, with not much success. Splitting it up into app modules might be best. |
Alright. I'll do that first on behalf of #94 . Note that you'll have a long way to go with multi-platform, as jsoup isn't multiplatform to begin with. |
Yeah, MP is more of a pipe dream than anything else at this point. More of an idea that i'm keeping in mind while I work on this. |
I've been looking into this a bit more, and it would seem that committing My recommendation:
Thoughts? |
I'm a fan of the third choice. I know there are instructions online but I don't like having to go through all that to get an app to build. I like making things one click build and one click test if possible. If you want you can even add a gradle script to auto copy it over if it doesn't exist. |
I was actually thinking of doing all of these things together, as opposed to them being 3 different approaches. But sounds good, that's what we'll do! |
I think we talked about this before, but unfortunately the app won't compile without the service json.
Not sure how other projects really deal with this (beyond requiring any contributor to get their own json), but one thing you could consider is splitting up the project in models. All the parsing doesn't depend on Android and pure kotlin devs can contribute. The general UI components (per application) do not depend on how data is fetched, and we can test their layouts through integration tests. Then you can package it all together, and other devs may not need to deal with google services at all.
The text was updated successfully, but these errors were encountered: