Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice warning or error if a column is used in an extractor but the table is not included in the from() clause #42

Open
nico78 opened this issue Jul 9, 2015 · 1 comment

Comments

@nico78
Copy link

nico78 commented Jul 9, 2015

Currently if a column is included in the where or select clause but the associated table is not included in the from() then sql is still produced referencing the column as if it had been included. Which can produce very cryptic error messages that are hard to track down the source of.

This is particularly likely if an extractor written for one query is reused for another similar query but with some tables omitted , say.

It would be good to have an error or warning that highlights if a column is being used without the associated table

@DavidGregory084
Copy link
Contributor

@brendanator, do you think we could potentially solve this with a solution like lihaoyi/scala.rx@4cb66a3? (The RxCtx that tracks the dependencies of the current code block)

I think potentially extractor.flatMap could be implemented with this pattern too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants