-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find unwrap()
and expect()
calls and eliminate them
#21
Comments
I highly recommend the https://github.com/yaahc/eyre#comparison-to-thiserror This will give you a useful path forward when you are chasing out all the unwraps. Also, remember that |
Is this still a problem? I'm willing to fix them. |
Yes, sort of. Please go ahead and submit a PR. Some cases may be fixable by writing comments why a panic is not possible. In some cases, such as taking locks, refactoring |
PR |
Either replace with more graceful error-handling or write comments to justify why panic cannot occur.
The text was updated successfully, but these errors were encountered: