Update cryptoki requirement from 0.7 to 0.8 #356
Annotations
2 errors and 11 warnings
|
Run giraffate/clippy-action@v1
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
|
Run giraffate/clippy-action@v1
reviewdog exited with status code: 1
|
|
The following actions use a deprecated Node.js version and will be forced to run on node20: giraffate/clippy-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run giraffate/clippy-action@v1:
src/messages/submessages/data.rs#L58
[clippy] reported by reviewdog 🐶
warning: empty line after doc comment
--> src/messages/submessages/data.rs:56:3
|
56 | / /// and expect_payload, which are told on submessage header flags.
57 | |
| |_^
58 | pub fn deserialize_data(buffer: &Bytes, flags: BitFlags<DATA_Flags>) -> io::Result<Self> {
| ---------------------------------------------------------------------------------------- the comment documents this associated function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
Raw Output:
src/messages/submessages/data.rs:58:3:w:warning: empty line after doc comment
--> src/messages/submessages/data.rs:56:3
|
56 | / /// and expect_payload, which are told on submessage header flags.
57 | |
| |_^
58 | pub fn deserialize_data(buffer: &Bytes, flags: BitFlags<DATA_Flags>) -> io::Result<Self> {
| ---------------------------------------------------------------------------------------- the comment documents this associated function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
__END__
|
|
Run giraffate/clippy-action@v1:
src/rtps/message_receiver.rs#L106
[clippy] reported by reviewdog 🐶
warning: empty line after doc comment
--> src/rtps/message_receiver.rs:104:1
|
104 | / /// Entities. (See RTPS spec Section 8.3.7)
105 | |
| |_^
106 | pub(crate) struct MessageReceiver {
| --------------------------------- the comment documents this struct
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
Raw Output:
src/rtps/message_receiver.rs:106:1:w:warning: empty line after doc comment
--> src/rtps/message_receiver.rs:104:1
|
104 | / /// Entities. (See RTPS spec Section 8.3.7)
105 | |
| |_^
106 | pub(crate) struct MessageReceiver {
| --------------------------------- the comment documents this struct
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
__END__
|
|
Run giraffate/clippy-action@v1:
src/structure/dds_cache.rs#L48
[clippy] reported by reviewdog 🐶
warning: empty line after doc comment
--> src/structure/dds_cache.rs:35:1
|
35 | / /// History policy, but must be preserved by a Writer's History Policy.
36 | |
| |_^
...
48 | pub struct DDSCache {
| ------------------- the comment documents this struct
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
|
36 | ///
|
Raw Output:
src/structure/dds_cache.rs:48:1:w:warning: empty line after doc comment
--> src/structure/dds_cache.rs:35:1
|
35 | / /// History policy, but must be preserved by a Writer's History Policy.
36 | |
| |_^
...
48 | pub struct DDSCache {
| ------------------- the comment documents this struct
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
|
36 | ///
|
__END__
|
|
Run giraffate/clippy-action@v1:
src/dds/participant.rs#L618
[clippy] reported by reviewdog 🐶
warning: the following explicit lifetimes could be elided: 'a
--> src/dds/participant.rs:618:6
|
618 | impl<'a> Stream for DomainParticipantStatusStream<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
618 - impl<'a> Stream for DomainParticipantStatusStream<'a> {
618 + impl Stream for DomainParticipantStatusStream<'_> {
|
Raw Output:
src/dds/participant.rs:618:6:w:warning: the following explicit lifetimes could be elided: 'a
--> src/dds/participant.rs:618:6
|
618 | impl<'a> Stream for DomainParticipantStatusStream<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
618 - impl<'a> Stream for DomainParticipantStatusStream<'a> {
618 + impl Stream for DomainParticipantStatusStream<'_> {
|
__END__
|
|
Run giraffate/clippy-action@v1:
src/dds/participant.rs#L640
[clippy] reported by reviewdog 🐶
warning: the following explicit lifetimes could be elided: 'a
--> src/dds/participant.rs:640:6
|
640 | impl<'a> FusedStream for DomainParticipantStatusStream<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
640 - impl<'a> FusedStream for DomainParticipantStatusStream<'a> {
640 + impl FusedStream for DomainParticipantStatusStream<'_> {
|
Raw Output:
src/dds/participant.rs:640:6:w:warning: the following explicit lifetimes could be elided: 'a
--> src/dds/participant.rs:640:6
|
640 | impl<'a> FusedStream for DomainParticipantStatusStream<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
640 - impl<'a> FusedStream for DomainParticipantStatusStream<'a> {
640 + impl FusedStream for DomainParticipantStatusStream<'_> {
|
__END__
|
|
Run giraffate/clippy-action@v1:
src/dds/statusevents.rs#L222
[clippy] reported by reviewdog 🐶
warning: the following explicit lifetimes could be elided: 'a
--> src/dds/statusevents.rs:222:6
|
222 | impl<'a, T> Stream for StatusReceiverStream<'a, T> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
222 - impl<'a, T> Stream for StatusReceiverStream<'a, T> {
222 + impl<T> Stream for StatusReceiverStream<'_, T> {
|
Raw Output:
src/dds/statusevents.rs:222:6:w:warning: the following explicit lifetimes could be elided: 'a
--> src/dds/statusevents.rs:222:6
|
222 | impl<'a, T> Stream for StatusReceiverStream<'a, T> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
222 - impl<'a, T> Stream for StatusReceiverStream<'a, T> {
222 + impl<T> Stream for StatusReceiverStream<'_, T> {
|
__END__
|
|
Run giraffate/clippy-action@v1:
src/dds/statusevents.rs#L245
[clippy] reported by reviewdog 🐶
warning: the following explicit lifetimes could be elided: 'a
--> src/dds/statusevents.rs:245:6
|
245 | impl<'a, T> FusedStream for StatusReceiverStream<'a, T> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
245 - impl<'a, T> FusedStream for StatusReceiverStream<'a, T> {
245 + impl<T> FusedStream for StatusReceiverStream<'_, T> {
|
Raw Output:
src/dds/statusevents.rs:245:6:w:warning: the following explicit lifetimes could be elided: 'a
--> src/dds/statusevents.rs:245:6
|
245 | impl<'a, T> FusedStream for StatusReceiverStream<'a, T> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
245 - impl<'a, T> FusedStream for StatusReceiverStream<'a, T> {
245 + impl<T> FusedStream for StatusReceiverStream<'_, T> {
|
__END__
|
|
Run giraffate/clippy-action@v1:
src/dds/key.rs#L34
[clippy] reported by reviewdog 🐶
warning: empty line after doc comment
--> src/dds/key.rs:32:1
|
32 | / /// [`Key`]: trait.Key.html
33 | |
| |_^
34 | pub trait Keyed {
| --------------- the comment documents this trait
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
Raw Output:
src/dds/key.rs:34:1:w:warning: empty line after doc comment
--> src/dds/key.rs:32:1
|
32 | / /// [`Key`]: trait.Key.html
33 | |
| |_^
34 | pub trait Keyed {
| --------------- the comment documents this trait
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
__END__
|
|
Run giraffate/clippy-action@v1:
src/dds/key.rs#L109
[clippy] reported by reviewdog 🐶
warning: empty line after doc comment
--> src/dds/key.rs:93:1
|
93 | / /// trait instead.
94 | |
| |_^
...
109 | / pub trait Key:
110 | | Eq + PartialEq + PartialOrd + Ord + Hash + Clone + Serialize + CdrEncodingSize
| |________________________________________________________________________________- the comment documents this trait
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
|
94 | ///
|
Raw Output:
src/dds/key.rs:109:1:w:warning: empty line after doc comment
--> src/dds/key.rs:93:1
|
93 | / /// trait instead.
94 | |
| |_^
...
109 | / pub trait Key:
110 | | Eq + PartialEq + PartialOrd + Ord + Hash + Clone + Serialize + CdrEncodingSize
| |________________________________________________________________________________- the comment documents this trait
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
|
94 | ///
|
__END__
|
|
Run giraffate/clippy-action@v1:
src/dds/no_key/wrappers.rs#L109
[clippy] reported by reviewdog 🐶
warning: empty line after outer attribute
--> src/dds/no_key/wrappers.rs:105:3
|
105 | / #[allow(clippy::unused_unit, clippy::semicolon_if_nothing_returned)]
106 | | // transform_decoded_key is supposed to return
107 | | // a value, but in this instance it is of type unit.
108 | |
| |_^
109 | fn transform_decoded_key(_decoded_key: Self::DecodedKey) -> () {
| -------------------------------------------------------------- the attribute applies to this associated function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr
= note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default
= help: if the empty line is unintentional remove it
Raw Output:
src/dds/no_key/wrappers.rs:109:3:w:warning: empty line after outer attribute
--> src/dds/no_key/wrappers.rs:105:3
|
105 | / #[allow(clippy::unused_unit, clippy::semicolon_if_nothing_returned)]
106 | | // transform_decoded_key is supposed to return
107 | | // a value, but in this instance it is of type unit.
108 | |
| |_^
109 | fn transform_decoded_key(_decoded_key: Self::DecodedKey) -> () {
| -------------------------------------------------------------- the attribute applies to this associated function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr
= note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default
= help: if the empty line is unintentional remove it
__END__
|
Loading