Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click commandline interfaces #54

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

dokempf
Copy link

@dokempf dokempf commented Oct 10, 2023

Rewrites CLIs to use the click library which will allow us to automatically generate a GUI using clickqt (an updated release of clickqt will come in the next days).

The new CLIs deviate slightly from the previous for both technical and consistency reasons. We have not discussed how hard this would be on you @jhennies and your users. If it matters a lot because of many existing scripts etc., I can try to further increase the compatibility (Example: I have not yet added short form options like -t for --target).

This fixes #48.

@dokempf
Copy link
Author

dokempf commented Oct 10, 2023

By the way, if we want to be a bit more conservative with these breaking changes, we could change the target branch for my changes to a new branch like ssc and then merge that to main when all current issues are implemented.

@jhennies
Copy link
Owner

The new CLIs deviate slightly from the previous for both technical and consistency reasons. We have not discussed how hard this would be on you @jhennies and your users. If it matters a lot because of many existing scripts etc., I can try to further increase the compatibility (Example: I have not yet added short form options like -t for --target).

I think in particular the --target option is very frequently used such that it would make life easier if the short -t was kept. On the other hand, since it is in practice used every time, we could also simply make it mandatory... Thinking about it, I would actually prefer that :)

@jhennies
Copy link
Owner

By the way, if we want to be a bit more conservative with these breaking changes, we could change the target branch for my changes to a new branch like ssc and then merge that to main when all current issues are implemented.

I agree, let's be conservative, considering we are currently actively using the software. I'll create the ssc branch

@dokempf dokempf changed the base branch from main to ssc October 11, 2023 11:19
@jhennies jhennies merged commit 6d3c136 into jhennies:ssc Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch command line interfaces to click
2 participants