Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tags that aren't explicitly supported #25

Open
ghost opened this issue Jul 17, 2020 · 5 comments
Open

Support for tags that aren't explicitly supported #25

ghost opened this issue Jul 17, 2020 · 5 comments

Comments

@ghost
Copy link

ghost commented Jul 17, 2020

Hi,

If I issue Get-AudioFile '.\test.flac' | Export-AudioFile LameMP3 ., tags that aren't explicitly supported are not carried over, "Disc number" and "Total discs", for instance. Nor are they visible in the metadata property of a TaggedAudioFile object.

Wouldn't it be a good idea to support all tags, including non-standard ones?

@jherby2k
Copy link
Owner

jherby2k commented Jul 17, 2020

It's hard to do as the tags are mapped between audio formats, and some (like ID3) are very particular about what's allowed and how they should be formatted. I'm certainly open to adding specific additional fields like the above.

@nonspin
Copy link

nonspin commented Aug 8, 2020

If for example the below Tags are present/set in the source ...

Disc                       : 1
DiscCount                  : 1

after conversion (no matter what Encoder/TagVersion/TagEncoding)
they are showing

Disc                       : 0
DiscCount                  : 0

not NULL, not Empty -> "0"

It seems like it's not setting them, because "TrackCount" is also set to "0"..
TrackCount can't be smaller than "Track", can it ?
"Track" however is set correctly

@jherby2k
Copy link
Owner

jherby2k commented Aug 8, 2020

There is no way its setting the Disc and DiscCount fields at all. What are you using to read the tags? Can you attach the file in question?

@regs01
Copy link

regs01 commented Sep 29, 2020

Sometimes there are multiple discs (volumes). Track number is given within of the volume, not of total.
There are m4a and mp3 examples. Zipped, as Guthub doesn't allow m4a and mp3 extensions.
test.zip

@jherby2k
Copy link
Owner

jherby2k commented Oct 3, 2020

Sometimes there are multiple discs (volumes). Track number is given within of the volume, not of total.
There are m4a and mp3 examples. Zipped, as Guthub doesn't allow m4a and mp3 extensions.
test.zip

Yes, i see that these have a disk # recorded in them. Currently, AudioWorks will strip those when re-writing the tags. I am going to address this in v1.1 by expanding the known tag dictionary. An alternative would be to simply save and restore unrecognized tags verbatim, but i'm not sure i want that feature - I like that AudioWorks re-writes the tag from scratch, as it can correct mistakes. Also that wouldn't help in a transcoding scenario.

@jherby2k jherby2k added this to the v1.1.0 milestone Oct 3, 2020
@jherby2k jherby2k modified the milestones: v1.1.0, v2.0.0 Nov 16, 2020
@jherby2k jherby2k removed their assignment Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants