Create a module to add Spring Native support #16498

mraible · 2021-09-30T20:33:43Z

Overview of the feature request

Create a module to add Spring Native support to JHipster apps.

Motivation for or Use Case

Josh Long and I figured out the necessary steps this week and documented them in mraible/spring-native-examples. I also published an article about our experience on LinkedIn.

Related issues or PR

#13733

Checking this box is mandatory (this is just to show you read everything)

mshima · 2021-09-30T20:39:05Z

I’m actually planning to add a modular generator.
Should be simple, but it’s a start.

I took a look at the steps. The modular generator will not help at the current state.

github-actions · 2021-10-31T00:07:06Z

This issue is stale because it has been open 30 days with no activity.
Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted.
We are accepting PRs 😃.
Comment or this will be closed in 7 days

mraible · 2021-10-31T00:18:43Z

I hope to work on this in a couple of weeks.

…

On Sat, Oct 30, 2021 at 18:07 github-actions[bot] ***@***.***> wrote: This issue is stale because it has been open 30 days with no activity. Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted. We are accepting PRs 😃. Comment or this will be closed in 7 days — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#16498 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAELZABRX2OP3IWMZ3HYMDUJSCDLANCNFSM5FDFMRLA> .

github-actions · 2021-12-01T00:10:25Z

This issue is stale because it has been open 30 days with no activity.
Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted.
We are accepting PRs 😃.
Comment or this will be closed in 7 days

mraible · 2021-12-01T00:23:18Z

I plan to start this next week. I was hoping we could upgrade to Spring Boot 2.6 first, but that might be difficult.

sdeleuze · 2021-12-01T09:47:47Z

Spring Native 0.11.0 should be released next week so good timing.

github-actions · 2022-01-01T00:08:07Z

This issue is stale because it has been open 30 days with no activity.
Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted.
We are accepting PRs 😃.
Comment or this will be closed in 7 days

mraible · 2022-01-01T18:48:35Z

Still plan to work on this once Spring Boot 2.6 is integrated.

…

On Fri, Dec 31, 2021 at 17:08 github-actions[bot] ***@***.***> wrote: This issue is stale because it has been open 30 days with no activity. Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted. We are accepting PRs 😃. Comment or this will be closed in 7 days — Reply to this email directly, view it on GitHub <#16498 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAELZEJGOQYJP6MX2OWF3LUTZAXFANCNFSM5FDFMRLA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

ozkanpakdil · 2022-01-24T23:39:42Z

Latest jhipster has SB 2.6.3 😃 watching this

mraible · 2022-02-04T18:57:22Z

@jhipster/developers Is our create a module guide up-to-date? I'd like to start creating this module today.

mshima · 2022-02-04T19:39:23Z

@mraible I would create a blueprint instead.
IMO we should drop module at v8, there is no advantage on implementing a module.
A blueprint acts as a module when using a custom command/generator.

mraible · 2022-02-04T21:20:05Z

@mshima If I create a blueprint, it'd likely only replace some values in needles. I suppose it might need to add files too.

Spring Boot 3 won't have a need for Spring Native because it'll be native by default. So that's something to consider - this likely won't be needed for JHipster 8 if it includes Spring Boot 3.

Another option would be to integrate Spring Native by default. Here's the current list of things you need to do to integrate it with JHipster v7.6. In my experience, integrating native does not cause any issues with JVM-mode. It's only activated when you run -Pnative.

Some of these issues might be bugs in Spring Native. spring-attic/spring-native#1378 (comment)

mshima · 2022-02-04T21:32:11Z

@mraible I can generate the initial blueprint if you want me to do it.

mraible · 2022-02-04T23:49:54Z

@mshima I'd love your help!

mshima · 2022-02-05T11:00:12Z

@mraible to regenerate your examples:

npm install -g mshima/generator-jhipster-native
jhipster-native --with-entities --skip-jhipster-dependencies

mraible · 2022-02-05T19:07:56Z

@mshima I tried it by running rm -rf in one of my example projects, then jhipster-native --with-entities. The result:

Changes to package.json were detected.

Running npm install for you to install the required dependencies.
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/generator-jhipster-native - Not found
npm ERR! 404
npm ERR! 404  '[email protected]' is not in this registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/mraible/.npm/_logs/2022-02-05T19_06_24_435Z-debug.log
ERROR! Command failed with exit code 1: npm install
Error: Command failed with exit code 1: npm install
    at makeError (/usr/local/lib/node_modules/generator-jhipster-native/node_modules/yeoman-environment/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/usr/local/lib/node_modules/generator-jhipster-native/node_modules/yeoman-environment/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  shortMessage: 'Command failed with exit code 1: npm install',
  command: 'npm install',
  escapedCommand: 'npm install',
  exitCode: 1,
  signal: undefined,
  signalDescription: undefined,
  stdout: undefined,
  stderr: undefined,
  failed: true,
  timedOut: false,
  isCanceled: false,
  killed: false
}

Would a clone and npm link work better?

mshima · 2022-02-05T19:13:28Z

Need to use --skip-jhipster-dependencies flag. The blueprint is not released.

mraible · 2022-02-05T22:12:28Z

I got a bit further. This time, it succeeded in creating the project, but fails to run it.

 jhipster: Compilation failure: Compilation failure:
[ERROR] /Users/mraible/dev/spring-native-examples/spring-native-webflux/src/main/java/com/mycompany/myapp/web/rest/LogoutResource.java:[38,104] cannot find symbol
[ERROR]   symbol:   variable idToken
[ERROR]   location: class com.mycompany.myapp.web.rest.LogoutResource
[ERROR] /Users/mraible/dev/spring-native-examples/spring-native-webflux/src/main/java/com/mycompany/myapp/web/rest/LogoutResource.java:[43,21] variable idToken is already defined in method prepareLogoutUri(org.springframework.http.server.reactive.ServerHttpRequest,org.springframework.security.oauth2.client.registration.ClientRegistration,org.springframework.security.oauth2.core.oidc.OidcIdToken)
[ERROR] /Users/mraible/dev/spring-native-examples/spring-native-webflux/src/main/java/com/mycompany/myapp/web/rest/LogoutResource.java:[43,31] cannot find symbol
[ERROR]   symbol:   variable oidcUser
[ERROR]   location: class com.mycompany.myapp.web.rest.LogoutResource
[ERROR] -> [Help 1]

mshima · 2022-02-06T13:12:50Z

I got a bit further. This time, it succeeded in creating the project, but fails to run it.

 jhipster: Compilation failure: Compilation failure:
[ERROR] /Users/mraible/dev/spring-native-examples/spring-native-webflux/src/main/java/com/mycompany/myapp/web/rest/LogoutResource.java:[38,104] cannot find symbol
[ERROR]   symbol:   variable idToken
[ERROR]   location: class com.mycompany.myapp.web.rest.LogoutResource
[ERROR] /Users/mraible/dev/spring-native-examples/spring-native-webflux/src/main/java/com/mycompany/myapp/web/rest/LogoutResource.java:[43,21] variable idToken is already defined in method prepareLogoutUri(org.springframework.http.server.reactive.ServerHttpRequest,org.springframework.security.oauth2.client.registration.ClientRegistration,org.springframework.security.oauth2.core.oidc.OidcIdToken)
[ERROR] /Users/mraible/dev/spring-native-examples/spring-native-webflux/src/main/java/com/mycompany/myapp/web/rest/LogoutResource.java:[43,31] cannot find symbol
[ERROR]   symbol:   variable oidcUser
[ERROR]   location: class com.mycompany.myapp.web.rest.LogoutResource
[ERROR] -> [Help 1]

Reactive LogoutResource needed adjusts.
Reinstalling should fix it.

PS: I am not really trying to run the applications.
I am following the steps and matching the examples, and doing generator-jhipster blueprint support adjusts.
Will do that later this week or next.

mraible · 2022-02-06T17:03:36Z

Thanks for the fix @mshima! I tested all of the apps today:

spring-native-webflux - ✅
spring-native-mvc - ✅
angular-webflux - ✅
postgres-webflux - ✅
postgres-mvc - ✅

I'll create a PR with some minor improvements to the blueprint.

mshima · 2022-02-06T17:06:48Z

We probably should move the blueprint to jhipster org.

mshima · 2022-02-06T17:20:13Z

Or hipster-labs due to GitHub actions.
The build is not completing in 35min 😮 .

mraible · 2022-02-06T18:23:22Z

@mshima I figured out how to get R2DBC repositories to work! I had to add @Component to each Impl class and add SimpleR2dbcRepository as a type hint. See specifics in mraible/spring-native-examples#7.

I also noticed that the JHipster Native blueprint does not add Liquibase information to the postgres-webflux example, so we might need to adjust some install logic there. I also had to add a typeName for Liquibase + WebFlux:

typeNames = "com.zaxxer.hikari.util.ConcurrentBag$IConcurrentBagEntry[]"

mraible · 2022-02-07T05:06:59Z

@mshima I found another thing that needs to be added. If CacheConfiguration is activated, it fails to compile with the following error.

[ERROR] Failed to execute goal org.springframework.experimental:spring-aot-maven-plugin:0.11.2:generate (generate) on project flickr-2: Build failed during Spring AOT code generation: Unable to execute mojo: Compilation failure
[ERROR] /Users/mraible/dev/auth0-full-stack-java-example/target/generated-runtime-sources/spring-aot/src/main/java/org/springframework/cache/annotation/ContextBootstrapInitializer.java:[24,56] cannot find symbol
[ERROR]   symbol:   method setConfigurers(java.lang.Object)
[ERROR]   location: variable bean of type org.springframework.cache.jcache.config.ProxyJCacheConfiguration
[ERROR] -> [Help 1]

If I add @Profile("!native") to CacheConfiguration, my app compiles. However, when I try to run it after building it, I still get an error:

2022-02-06 22:04:13.178 ERROR 25028 --- [           main] org.hibernate.AssertionFailure           : HHH000099: an assertion failure occurred (this may indicate a bug in Hibernate, but is more likely due to unsafe use of the session): java.lang.NullPointerException
2022-02-06 22:04:13.186 ERROR 25028 --- [           main] o.s.boot.SpringApplication               : Application run failed

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'entityManagerFactory': Invocation of init method failed; nested exception is org.hibernate.AssertionFailure: Error calling ServiceLoader.Provider.type()
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1804) ~[na:na]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:620) ~[na:na]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542) ~[na:na]
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335) ~[na:na]
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234) ~[na:na]
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333) ~[na:na]
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208) ~[na:na]
	at org.springframework.context.support.AbstractApplicationContext.getBean(AbstractApplicationContext.java:1154) ~[na:na]
	at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:908) ~[na:na]
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583) ~[na:na]
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:145) ~[na:na]
	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:732) ~[native-executable:2.6.3]
	at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:414) ~[native-executable:2.6.3]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:302) ~[native-executable:2.6.3]
	at com.auth0.flickr2.Flickr2App.main(Flickr2App.java:80) ~[native-executable:na]
Caused by: org.hibernate.AssertionFailure: Error calling ServiceLoader.Provider.type()
	at org.hibernate.boot.registry.classloading.internal.AggregatedServiceLoader$ClassPathAndModulePathAggregatedServiceLoader.collectServiceIfNotDuplicate(AggregatedServiceLoader.java:272) ~[na:na]
	at org.hibernate.boot.registry.classloading.internal.AggregatedServiceLoader$ClassPathAndModulePathAggregatedServiceLoader.loadAll(AggregatedServiceLoader.java:201) ~[na:na]
	at org.hibernate.boot.registry.classloading.internal.AggregatedServiceLoader$ClassPathAndModulePathAggregatedServiceLoader.getAll(AggregatedServiceLoader.java:187) ~[na:na]
	at org.hibernate.boot.registry.classloading.internal.ClassLoaderServiceImpl.loadJavaServices(ClassLoaderServiceImpl.java:251) ~[na:na]
	at org.hibernate.boot.registry.selector.internal.StrategySelectorBuilder.buildSelector(StrategySelectorBuilder.java:105) ~[na:na]
	at org.hibernate.boot.registry.BootstrapServiceRegistryBuilder.build(BootstrapServiceRegistryBuilder.java:232) ~[na:na]
	at org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl.buildBootstrapServiceRegistry(EntityManagerFactoryBuilderImpl.java:479) ~[na:na]
	at org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl.<init>(EntityManagerFactoryBuilderImpl.java:222) ~[na:na]
	at org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl.<init>(EntityManagerFactoryBuilderImpl.java:182) ~[na:na]
	at org.springframework.orm.jpa.vendor.SpringHibernateJpaPersistenceProvider.createContainerEntityManagerFactory(SpringHibernateJpaPersistenceProvider.java:52) ~[na:na]
	at org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean.createNativeEntityManagerFactory(LocalContainerEntityManagerFactoryBean.java:365) ~[na:na]
	at org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.buildNativeEntityManagerFactory(AbstractEntityManagerFactoryBean.java:409) ~[na:na]
	at org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.afterPropertiesSet(AbstractEntityManagerFactoryBean.java:396) ~[na:na]
	at org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean.afterPropertiesSet(LocalContainerEntityManagerFactoryBean.java:341) ~[na:na]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1863) ~[na:na]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1800) ~[na:na]
	... 14 common frames omitted
Caused by: java.lang.NullPointerException: null
	at org.hibernate.boot.registry.classloading.internal.AggregatedServiceLoader$ClassPathAndModulePathAggregatedServiceLoader.collectServiceIfNotDuplicate(AggregatedServiceLoader.java:269) ~[na:na]
	... 29 common frames omitted

mraible · 2022-02-07T05:19:57Z

Upon further review, it seems that the profile annotation does not work and I have to comment out these annotations in CacheConfiguration.

@Configuration
@EnableCaching

This still results in the same error as above. I also tried to disable Hibernate's 2nd level cache in application.yml.

hibernate.cache.use_second_level_cache: false

That doesn't seem to help either. I'll continue investigating.

mshima · 2022-02-07T17:42:29Z

Added warnings for untested configurations.

mraible · 2022-02-07T18:37:44Z

Good idea. I had to remove caching for things to work. I added a workaround to my instructions. I believe this is because Spring Native doesn't support caching yet.

mraible · 2022-02-10T22:17:33Z

@mshima If you transfer your repo to @jdubois, he can transfer it to the JHipster org.

mshima · 2022-02-10T23:10:01Z

@mshima If you transfer your repo to @jdubois, he can transfer it to the JHipster org.

Done

jdubois · 2022-02-11T09:17:37Z

And the transfer to the org is done! Thanks!

…

On 11 Feb 2022, at 00:10, Marcelo Shima ***@***.***> wrote: @mshima <https://github.com/mshima> If you transfer your repo to @jdubois <https://github.com/jdubois>, he can transfer it to the JHipster org. Done — Reply to this email directly, view it on GitHub <#16498 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACNLI7YHWJA27D2U36H6T3U2RAVLANCNFSM5FDFMRLA>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.

mraible · 2022-02-17T21:26:43Z

Just so folks know when reading this conversation, the blueprint is located at https://github.com/jhipster/generator-jhipster-native.

DanielFran · 2022-05-13T17:17:00Z

@mraible @mshima Closing this issue since blueprint is now available ;)

mraible · 2022-05-13T21:00:47Z

Please grab the bug bounty for this one @mshima!

mshima · 2022-06-22T12:39:40Z

Bug bounty claimed https://opencollective.com/generator-jhipster/expenses/83301

DanielFran · 2022-06-22T12:42:52Z

@mshima: approved

mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ labels Sep 30, 2021

github-actions bot added the area: stale label Oct 31, 2021

github-actions bot removed the area: stale label Nov 1, 2021

github-actions bot added the area: stale label Dec 1, 2021

github-actions bot removed the area: stale label Dec 2, 2021

mraible mentioned this issue Dec 7, 2021

Migrate to SpringDoc. jhipster/jhipster-bom#556

Merged

github-actions bot added the area: stale label Jan 1, 2022

github-actions bot removed the area: stale label Jan 2, 2022

mraible mentioned this issue Feb 6, 2022

JPA not able to render entities with relationships in JHipster 7.6 #17794

Closed

This was referenced Feb 6, 2022

Minor improvements to JHipster Native blueprint jhipster/generator-jhipster-native#1

Merged

Regenerate all apps with JHipster Native blueprint mraible/spring-native-examples#6

Merged

mshima mentioned this issue Feb 6, 2022

Misc fixes and improvements. #17795

Merged

6 tasks

mshima closed this as completed Feb 10, 2022

mshima reopened this Feb 10, 2022

DanielFran closed this as completed May 13, 2022

DanielFran added area: feature request 💡 theme: blueprint 🐾 labels May 13, 2022

DanielFran added this to the 7.9.0 milestone Jun 22, 2022

Create a module to add Spring Native support #16498

Create a module to add Spring Native support #16498

Comments

mraible commented Sep 30, 2021

Overview of the feature request

Motivation for or Use Case

Related issues or PR

mshima commented Sep 30, 2021 • edited Loading

github-actions bot commented Oct 31, 2021

mraible commented Oct 31, 2021 via email

github-actions bot commented Dec 1, 2021

mraible commented Dec 1, 2021

sdeleuze commented Dec 1, 2021

github-actions bot commented Jan 1, 2022

mraible commented Jan 1, 2022 via email

ozkanpakdil commented Jan 24, 2022

mraible commented Feb 4, 2022

mshima commented Feb 4, 2022

mraible commented Feb 4, 2022

mshima commented Feb 4, 2022

mraible commented Feb 4, 2022

mshima commented Feb 5, 2022 • edited Loading

mraible commented Feb 5, 2022

mshima commented Feb 5, 2022

mraible commented Feb 5, 2022

mshima commented Feb 6, 2022

mraible commented Feb 6, 2022

mshima commented Feb 6, 2022

mshima commented Feb 6, 2022

mraible commented Feb 6, 2022

mraible commented Feb 7, 2022 • edited Loading

mraible commented Feb 7, 2022

mshima commented Feb 7, 2022

mraible commented Feb 7, 2022

mraible commented Feb 10, 2022

mshima commented Feb 10, 2022

jdubois commented Feb 11, 2022 via email

mraible commented Feb 17, 2022

DanielFran commented May 13, 2022

mraible commented May 13, 2022

mshima commented Jun 22, 2022

DanielFran commented Jun 22, 2022

mshima commented Sep 30, 2021 •

edited

Loading

mshima commented Feb 5, 2022 •

edited

Loading

mraible commented Feb 7, 2022 •

edited

Loading