Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing broken default url #13

Closed
wants to merge 3 commits into from
Closed

changing broken default url #13

wants to merge 3 commits into from

Conversation

enxebre
Copy link
Contributor

@enxebre enxebre commented May 30, 2014

No description provided.

@jhoblitt
Copy link
Owner

I just discovered this myself. The download path has changed to: https://selenium-release.storage.googleapis.com/index.html

This PR doesn't handle the new URL scheme correctly as $version needs to be parsed down to major.minor for the parent path component.

jhoblitt pushed a commit that referenced this pull request May 31, 2014
@jhoblitt
Copy link
Owner

@enxebre I've tweaked the PR to handle the partial version component that's now part of the URL and merged it as c500ad7. Thank you for fixing this! I will be making a new forge release soon.

@jhoblitt jhoblitt closed this May 31, 2014
@jhoblitt
Copy link
Owner

jhoblitt commented Jun 1, 2014

I pushed v0.2.3 to the forge. Thank you again!

@enxebre
Copy link
Contributor Author

enxebre commented Jun 2, 2014

Sorry I haven't been available until now. Awesome, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants